Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Run rucio/rucio integ tests for PRs in rucio/containers #310

Open
rdimaio opened this issue May 7, 2024 · 1 comment
Open

Testing: Run rucio/rucio integ tests for PRs in rucio/containers #310

rdimaio opened this issue May 7, 2024 · 1 comment

Comments

@rdimaio
Copy link
Contributor

rdimaio commented May 7, 2024

for PRs in rucio/containers, we could pull rucio/rucio:master and run the integ tests with the changes in the PR, to catch possible errors in advance

@rdimaio
Copy link
Contributor Author

rdimaio commented May 10, 2024

This syntax can be used https://stackoverflow.com/a/63822945 to conditionally do something depending on the push path in the PR. This way, we could make the GH workflow only build the containers that have been changed in the PR, and pull the remaining containers from the latest release on Docker Hub (similarly to how we do integ tests in rucio/rucio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant