Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage in PR reviews (and possibly in CI) #6545

Open
rdimaio opened this issue Mar 12, 2024 · 0 comments
Open

Test coverage in PR reviews (and possibly in CI) #6545

rdimaio opened this issue Mar 12, 2024 · 0 comments
Assignees
Labels

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Mar 12, 2024

Rucio used to have test coverage some time ago, but it was toggled off. I think it would be a good tool to have for PR review purposes; if there is a portion of code that is not covered, it might be a good indicator that some tests need to be written for that part of the code.

As we use pytest for testing, we can use https://github.com/pytest-dev/pytest-cov for coverage.

There are some criticisms for using coverage as a metric: the main reason behind this is that coverage only tells you whether code is covered or not, but it doesn't tell you much about the quality of the tests. I somewhat agree with this, and I would suggest only using coverage as a PR review tool, but we could also consider having a fairly achievable coverage threshold (60-70%) and aiming to always be over that threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants