Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving docstrings #6628

Open
rdimaio opened this issue Apr 3, 2024 · 2 comments
Open

Improving docstrings #6628

rdimaio opened this issue Apr 3, 2024 · 2 comments

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Apr 3, 2024

Partly related to: rucio/documentation#287.

It seems like there is no single style for docstrings in Rucio, e.g.:

For the docstring blocks:

For returns:

For exceptions:

I think we should agree on:

  • What format we should use for docstrings
  • Where do we want to add docstrings
  • Whether to automatically generate documentation from docstrings
@voetberg
Copy link
Contributor

voetberg commented Apr 3, 2024

Some automatic generation is already done for the API/Client - https://github.com/rucio/documentation/blob/main/tools/run_in_docker/generate_client_api_docs.sh , but I do agree

rdimaio added a commit to rdimaio/rucio that referenced this issue Apr 23, 2024
rdimaio added a commit to rdimaio/rucio that referenced this issue Apr 23, 2024
rdimaio added a commit to rdimaio/rucio that referenced this issue Apr 23, 2024
bari12 pushed a commit that referenced this issue May 6, 2024
bari12 pushed a commit that referenced this issue May 6, 2024
@bari12 bari12 closed this as completed May 6, 2024
@rdimaio
Copy link
Contributor Author

rdimaio commented May 6, 2024

Reopening as that was only an initial PR, there is still some extra work to be done

@rdimaio rdimaio reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants