Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper args to generate_qa_pairs #14054

Merged

Conversation

AndreasThinks
Copy link
Contributor

Description

Added various helper args to generate_qa_pairs to help with large datasets.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
the generate_qa_pairs function should now properly resume if there is an error, and allow iterative saving over time

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@AndreasThinks AndreasThinks marked this pull request as ready for review June 12, 2024 09:36
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@logan-markewich logan-markewich enabled auto-merge (squash) June 18, 2024 03:47
@logan-markewich logan-markewich merged commit 2c1577d into run-llama:main Jun 18, 2024
8 checks passed
@AndreasThinks AndreasThinks deleted the improve_generate_qa_pairs branch June 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants