Skip to content

Fix parsing sql query.py #14109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Fix parsing sql query.py #14109

merged 6 commits into from
Jun 14, 2024

Conversation

Thomas-AH-Heller
Copy link
Contributor

Description

Sometime the parsing was not working properly for the sql query engine. LLM sometimes started the answer with SQLQuery:, or used markdown, it would even comment between the end of the sql query and the final result.
This was test with mistral AI, Open AI, llama 2/3 and wizard LM. It improved the parsing for all of them, leading to no new bug detected due to the new parsing.

Fixes # (issue)

New Package?

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Sorry, something went wrong.

Thomas-AH-Heller and others added 2 commits June 12, 2024 18:04
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 12, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thomas-AH-Heller. Would it be possible to add a unit tests for each of the conditions that you're checking for?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 14, 2024
@Thomas-AH-Heller
Copy link
Contributor Author

Thanks @Thomas-AH-Heller. Would it be possible to add a unit tests for each of the conditions that you're checking for?

@nerdai Done !

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thomas-AH-Heller for the fix and adding the unit tests -- much appreciated!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2024
@nerdai nerdai merged commit a7b5587 into run-llama:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants