Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function calling #14453

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix function calling #14453

merged 1 commit into from
Jun 28, 2024

Conversation

logan-markewich
Copy link
Collaborator

Function calling should work when

  • tools are not provided
  • no tools are called

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 28, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2024
@logan-markewich logan-markewich merged commit cba6e63 into main Jun 28, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/various_fix branch June 28, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants