Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support github codeowners with branch protection on codeowners #4450

Open
nitrocode opened this issue Apr 17, 2024 · 1 comment
Open

Support github codeowners with branch protection on codeowners #4450

nitrocode opened this issue Apr 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nitrocode
Copy link
Member

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Approval by non-codeowner allows the apply and fails to merge

Reproduction Steps

The github repo has codeowners
The branch protections enforce codeowners
The pr was approved by a NON codeowner
atlantis apply was commented
terraform apply was run (which shouldn't have happened)
pr failed to merge
atlantis/apply pr check is in a failed state

Logs

n/a

Environment details

0.27.2

Additional Context

n/a

@nitrocode nitrocode added the bug Something isn't working label Apr 17, 2024
@stasostrovskyi
Copy link
Contributor

Atlantis cannot reflect every single permutation of what people consider a PR to be ok to be applied/merged, but GitHub can. So I guess right way forward is to use mergeable as apply_requirement and configure everything else in branch protection/rulesets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants