Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis comment with targets can fail if the address contains a string with a github autolink #4486

Open
nitrocode opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nitrocode
Copy link
Member

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Github autolinks are used to create hyperlinks of tickets.

For example, an autolink could be used for a case-insensitive string like WEB-123 to turn this into a markdown hyperlink of [WEB-123](https://someorg.atlassian.net/browse/WEB-123.

If this string happens to be in a resource address, then atlantis will throw an error because it does not strip the markdown from the comment.

i.e.

atlantis plan -- -target 'aws_route53_record["web-123"]'

will throw an error

Reproduction Steps

  1. create an autolink in github repo for web-123
  2. create a resource with an address containing the ticket
  3. attempt a targeted plan
  4. observe the error

Logs

Environment details

Additional Context

@nitrocode nitrocode added the bug Something isn't working label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant