Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WindowAggregate::value pass mutable value ref #1395

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Oct 6, 2023

Fixes #1394

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (476a02a) 81.33% compared to head (3b70307) 81.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
+ Coverage   81.33%   81.35%   +0.01%     
==========================================
  Files          49       49              
  Lines       10229    10227       -2     
==========================================
  Hits         8320     8320              
+ Misses       1909     1907       -2     
Files Coverage Δ
src/functions.rs 87.25% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyurik
Copy link
Contributor Author

nyurik commented Oct 6, 2023

Seems like there is an unrelated Clippy issue. I can submit a PR for auto-checking that, similar to what I have in my crate:

  • automatically adds a git-push hook to run cargo clippy && cargo test before pushing (and explains how to skip it)
  • use justfile (not required, but convenient) for all sorts of dev life automation

@nyurik
Copy link
Contributor Author

nyurik commented Oct 21, 2023

@gwenn hi, a friendly ping - let me know if anything else is needed here and in other PRs. Thanks!!

@gwenn gwenn merged commit 46430e0 into rusqlite:master Oct 22, 2023
16 checks passed
@nyurik nyurik deleted the mut-window-value branch October 22, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom window functions and mutability
2 participants