Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sqlite3_reset result #1419

Merged
merged 3 commits into from Nov 25, 2023
Merged

Check sqlite3_reset result #1419

merged 3 commits into from Nov 25, 2023

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Nov 25, 2023

https://sqlite.org/c3ref/reset.html

Therefore, it is important that applications check the return code from sqlite3_reset(S) even if no prior call to sqlite3_step(S) indicated a problem.

Fix #1418

https://sqlite.org/c3ref/reset.html
> Therefore, it is important that applications check the return code from sqlite3_reset(S) even if no prior call to sqlite3_step(S) indicated a problem.
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7f8c421) 81.23% compared to head (9ebca71) 81.25%.

Files Patch % Lines
src/statement.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   81.23%   81.25%   +0.02%     
==========================================
  Files          50       50              
  Lines       10299    10298       -1     
==========================================
+ Hits         8366     8368       +2     
+ Misses       1933     1930       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

just to keep code coverage the same
@gwenn gwenn merged commit 75bd09d into rusqlite:master Nov 25, 2023
16 checks passed
@gwenn gwenn deleted the reset branch November 25, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check sqlite3_reset usages
1 participant