Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_from_handle fails to build on systems with unsigned c_char #1420

Closed
plugwash opened this issue Dec 14, 2023 · 3 comments · Fixed by #1421
Closed

test_from_handle fails to build on systems with unsigned c_char #1420

plugwash opened this issue Dec 14, 2023 · 3 comments · Fixed by #1421
Labels
bug

Comments

@plugwash
Copy link

Debian CI discovered that test_from_handle_owned fails to build on systems with unsigned c_char. The fix is trivial, the typecast just needs to be changed from *const i8 to *const c_char.

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/529c3c84306436a723ea0f1595465fa61017b988/src/rusqlite/debian/patches/fix-tests-unsigned-char.patch
@gwenn gwenn added the bug label Dec 14, 2023
@gwenn
Copy link
Collaborator

gwenn commented Dec 14, 2023

https://github.com/rusqlite/rusqlite/blame/c2fbd167dec8b043524a11df8a471120008669dd/src/lib.rs#L1884

@gwenn gwenn mentioned this issue Dec 16, 2023
Merged
@gwenn
Copy link
Collaborator

gwenn commented Dec 16, 2023

Thanks.

@gwenn
Copy link
Collaborator

gwenn commented Feb 17, 2024

Version 0.31.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply patch gwenn/rusqlite
2 participants
@gwenn @plugwash