Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the include directory of the bundled sqlite version #1441

Merged
merged 1 commit into from Jan 25, 2024

Conversation

weiznich
Copy link
Contributor

This commit exposes the include directory of the bundled sqlite version via by instructing cargo to set the DEP_SQLITE3_INCLUDE enviroment variable as documented in the cargo book:
https://doc.rust-lang.org/cargo/reference/build-script-examples.html#using-another-sys-crate

This enables other sys crates to rely on the bundled sqlite version and use it as base for their compilation if they have a (sub-)dependency on libsqlite3.

This commit exposes the include directory of the bundled sqlite version
via by instructing cargo to set the `DEP_SQLITE3_INCLUDE` enviroment
variable as documented in the cargo book:
https://doc.rust-lang.org/cargo/reference/build-script-examples.html#using-another-sys-crate

This enables other sys crates to rely on the bundled sqlite version and
use it as base for their compilation if they have a (sub-)dependency on
libsqlite3.
@gwenn
Copy link
Collaborator

gwenn commented Jan 25, 2024

@weiznich
Copy link
Contributor Author

As that's a feature of build.rs files you would need to search for lang:rust and not for lang:toml, right?

https://github.com/search?q=lang%3ARust++%22cargo%3Ainclude%3D%22&type=code

Or is that trying to say: Noone is using libsqlite3-sys in that way yet?

@gwenn
Copy link
Collaborator

gwenn commented Jan 25, 2024

As that's a feature of build.rs files you would need to search for lang:rust and not for lang:toml, right?

Sorry, you are right.
And I guess we can ignore the code coverage error.

@gwenn gwenn merged commit 42a82fb into rusqlite:master Jan 25, 2024
12 of 13 checks passed
@weiznich
Copy link
Contributor Author

Thanks for the fast response ❤️

@gwenn
Copy link
Collaborator

gwenn commented Jan 27, 2024

libsqlite3-sys v0.28.0 released

@weiznich
Copy link
Contributor Author

Thanks ❤️

@gwenn gwenn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants