Downloading the binaries through a proxy #49
Conversation
Cargo.toml
Outdated
| @@ -18,7 +18,7 @@ home = "0.5.3" # use same ver in build-dep | |||
| env_logger = "0.8" | |||
|
|
|||
| [build-dependencies] | |||
| ureq = "1.0" # allows to keep MSRV 1.41.1 | |||
| ureq = "2.1" | |||
There was a problem hiding this comment.
I hope it's ok to use the same version as electrsd. With this old version, the proxying didn't work, or at least not the same way as in electrsd.
There was a problem hiding this comment.
sorry for not giving an update on this but I prefer to put this in standby at the moment
ulrichard
force-pushed
the
feature/proxy
branch
from
2b95f70
to
faa9230
Compare
ulrichard
force-pushed
the
feature/proxy
branch
2 times, most recently
from
93df4cd
to
6e8ba5e
Compare
ulrichard
force-pushed
the
feature/proxy
branch
2 times, most recently
from
09fb8d2
to
5c83cc7
Compare
ulrichard
force-pushed
the
feature/proxy
branch
2 times, most recently
from
f57ec64
to
8b0fc8e
Compare
|
After #102 I would be inclined to accept this if you want to fix conflicts |
ulrichard
force-pushed
the
feature/proxy
branch
from
8b0fc8e
to
388a6b3
Compare
|
ok, rebased. |
ulrichard
force-pushed
the
feature/proxy
branch
from
388a6b3
to
a697cc6
Compare
|
I don't think the CI build error in 1.41.1 has anything to do with my changes. |
There was a problem hiding this comment.
I don't think the CI build error in 1.41.1 has anything to do with my changes.
It doesn't which dep broke msrv with their new 4.4.0 version... Don't know what is best to do if pinning the dep or including a Cargo.lock, @Kixunil what do you think?
UPDATE: I'll go with this suggestion instead #104 (comment)
In the meantime I changed the strategy with our CI a bit. Now RCasatta/electrsd#51 would be more important to me,
I'll do my best to tackle that one too
| @@ -114,10 +114,19 @@ mod download { | |||
| ); | |||
| println!("url:{}", url); | |||
| let mut downloaded_bytes = Vec::new(); | |||
| let resp = ureq::get(&url).call().unwrap(); | |||
| assert_eq!(resp.status(), 200, "url {} didn't return 200", url); | |||
There was a problem hiding this comment.
I don't remember exactly why this assert is here but maybe it helps with reporting? Can we restore it?
ulrichard
force-pushed
the
feature/proxy
branch
from
a697cc6
to
aae9db7
Compare
.github/workflows/test.yml
Outdated
| - uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: update | ||
| args: -p which --precise 4.3.0 |
There was a problem hiding this comment.
Yeah, this is one of two good ways I know of to resolve the MSRV problem.
…P_PROXY environment variable is set. closes rust-bitcoin#48
ulrichard
force-pushed
the
feature/proxy
branch
from
aae9db7
to
282212f
Compare
Downloading the binaries through a proxy if either HTTPS_PROXY or HTTP_PROXY environment variable is set.
closes #48