{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":22862033,"defaultBranch":"master","name":"rust-secp256k1","ownerLogin":"rust-bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-12T02:27:27.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/37084147?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712094754.0","currentOid":""},"activityList":{"items":[{"before":"1e814e76392391fa04edbe06b85117cbac6b0d0b","after":"6648126c69ce8056d053cbaa22246d12c76f3fc1","ref":"refs/heads/master","pushedAt":"2024-04-02T21:51:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#685: Release tracking PR: `v0.29.0`\n\n5f9baaa7d5f6ff84dafb780a3ab90afcdb1dd5a9 Bump version to 0.29.0 (Tobin C. Harding)\n\nPull request description:\n\n In preparation for release add a dummy changelog entry and bump the version.\n\nACKs for top commit:\n apoelstra:\n ACK 5f9baaa7d5f6ff84dafb780a3ab90afcdb1dd5a9\n\nTree-SHA512: 1c58dfbc5c55402aae25e50ff096b7af0cc3d85fef05297f597edea264f9a7534983a2a9e79c15e6514142321c71ea8b48a8b80da960e933d2a155162e6e41b4","shortMessageHtmlLink":"Merge #685: Release tracking PR: v0.29.0"}},{"before":"a05078f6e58e2b41997c0dbf7401266fab7d76f6","after":"1e814e76392391fa04edbe06b85117cbac6b0d0b","ref":"refs/heads/master","pushedAt":"2024-04-02T20:33:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#688: Release tracking PR: `secp256k1-sys 0.10.0`\n\n2bba8f9f5a7ea8af619a0df0afb4f36f3e00013a secp256k1-sys: Vendor latest secp256k1 (Tobin C. Harding)\n\nPull request description:\n\n Vendor latest tagged version of `secp256k1` and prepare for release:\n\n - Bump the version number to `0.10.0`\n - Run the vendor script (vendoring `secp256k1 0.4.1`)\n - Update lock files\n - Add changelog entry\n - Depend on new version in `secp256k1/Cargo.toml`\n\nACKs for top commit:\n apoelstra:\n ACK 2bba8f9f5a7ea8af619a0df0afb4f36f3e00013a\n\nTree-SHA512: 86ab44574d31657f0c99d32a7cf950a54deda4eac6f67ab08cb08a04aa60e65e268893fc1d158fb9895745963c687416c0158e693250d41cefdaf2b71583ff96","shortMessageHtmlLink":"Merge #688: Release tracking PR: secp256k1-sys 0.10.0"}},{"before":"d279c13bebc5886bf82009d137954f74d017c5ad","after":"a05078f6e58e2b41997c0dbf7401266fab7d76f6","ref":"refs/heads/master","pushedAt":"2024-04-02T00:52:15.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#686: Deprecate `ThirtyTwoByteHash`\n\n9f28cf6ad01157da2dfb35639db7f624f958cc69 Deprecate ThirtyTwoByteHash (Tobin C. Harding)\n88c8c58d8d914279f8aa809413fd53f4929f7de4 Fix import warnings (Tobin C. Harding)\n\nPull request description:\n\n The implementations of `ThirtyTwoByteHash` for types from the `hashes` crate are problematic during upgrades because both `bitcoin` and `secp256k1` depend on `hashes` and when the versions of `hashes` get out of sync usage of the trait breaks.\n\n Deprecate the `ThirtyTwoByteHash` trait and remove the impls for types from `bitcoin_hashes`.\n\n Add an explanation in the changelog because its too long to go in the deprecation message.\n\n Close: #673\n\nACKs for top commit:\n apoelstra:\n ACK 9f28cf6ad01157da2dfb35639db7f624f958cc69\n\nTree-SHA512: a7598b09c6a2f49913a9effad3e1ed9b0663970ac20fbfe5fc2f1329daaa2b4cab78b00128a03d0f3f6559ed7964b09e0bd939e60cf130b2cc6e609c90df6868","shortMessageHtmlLink":"Merge #686: Deprecate ThirtyTwoByteHash"}},{"before":"ac706178bff5f0c5f4a848c44164449420e8b56a","after":"d279c13bebc5886bf82009d137954f74d017c5ad","ref":"refs/heads/master","pushedAt":"2024-03-28T21:08:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#690: Upgrade hashes dependency\n\n645271dd7456017e3040a7f5eecae74da947d64c Upgrade hashes dependency (Tobin C. Harding)\n\nPull request description:\n\n Keep the range versioning but increase the threshold to include the latest `v0.14.0` release.\n\nACKs for top commit:\n apoelstra:\n ACK 645271dd7456017e3040a7f5eecae74da947d64c\n\nTree-SHA512: 46c93e4ad4077cc164e546fd9621f18ec34c2e110f9c763e8252d3ee92174e9efb5a20eea6169f62d5397fcbab5799dd8d9c88577bbf246e9aa4c2b2282c2266","shortMessageHtmlLink":"Merge #690: Upgrade hashes dependency"}},{"before":"b370f6704d459d2998cbc807feadd3f9074268ac","after":"ac706178bff5f0c5f4a848c44164449420e8b56a","ref":"refs/heads/master","pushedAt":"2024-03-28T13:40:43.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#693: Bump MSRV to 1.56.1\n\n2d0c7835f153962ca6cacce7532a70c00fda42c4 Tighten the version grep in vendor script (Tobin C. Harding)\na2b78f402229607dec1766173a061b5ad5d35e1a Bump MSRV to 1.56.1 (Tobin C. Harding)\n\nPull request description:\n\n As we have done in other parts of the ecosystem bump the MSRV to Rust `v1.56.1`.\n\n Done for `secp256k1` and `secp256k1-sys`.\n\n This was originally in #688 but there are too many things going on so here it is separately.\n\nACKs for top commit:\n apoelstra:\n ACK 2d0c7835f153962ca6cacce7532a70c00fda42c4\n\nTree-SHA512: 35ac5632428211b02f5b25780c3a680d8c9a68b238de7299242510091f9243fe2f6718817c865c3420e3afb64b32d52daf2cf372706067204e7de42e188c31c6","shortMessageHtmlLink":"Merge #693: Bump MSRV to 1.56.1"}},{"before":"1674406b1bf03ed9b8bee422e2213b069147a55c","after":"b370f6704d459d2998cbc807feadd3f9074268ac","ref":"refs/heads/master","pushedAt":"2024-03-27T19:07:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#682: Remove wildcard re-exports\n\n0da394e64848baf93c0aca0a9d6b5c9b2648b908 Remove wildcard re-exports of key types (Tobin C. Harding)\nd63e95b99b5183aa181a82eee89727f290a6c82d Remove wildcard re-exports of context types (Tobin C. Harding)\n\nPull request description:\n\n Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit.\n\n - Patch 1: Re-export the `context` types explicitly.\n - Patch 2: Re-export the `key` types explicitly.\n\n Fix: #681\n\nACKs for top commit:\n apoelstra:\n ACK 0da394e64848baf93c0aca0a9d6b5c9b2648b908\n\nTree-SHA512: ac92baa9b9abaaff436223bf1d18d286825dbfc8eef401c714314902ff471db4830dce360138845efd781bcb883676d0cbc3db8d691476403eb487a0585edeaa","shortMessageHtmlLink":"Merge #682: Remove wildcard re-exports"}},{"before":"d5f8b2abffe2ad68fb1c1f722e5b7214dd164af7","after":"1674406b1bf03ed9b8bee422e2213b069147a55c","ref":"refs/heads/master","pushedAt":"2024-03-27T18:44:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#692: CI: Revert cc pin in ASAN job\n\n7b6a13b0041ca9a1b48408b324110f708a33fef4 CI: Revert cc pin in ASAN job (Tobin C. Harding)\n\nPull request description:\n\n Revert commit: 92778efe926b673f04e2935af50314db99cf8244\n\n We can't use git to revert it because the code has now moved from `test.sh` to `_test.sh`.\n\n I don't remember the problem but lets just use CI to see if its fixed.\n\nACKs for top commit:\n sanket1729:\n utACK 7b6a13b0041ca9a1b48408b324110f708a33fef4\n apoelstra:\n ACK 7b6a13b0041ca9a1b48408b324110f708a33fef4\n\nTree-SHA512: d804c73152b3d8b14e8f13e64066c33e2dfbdef8b184d55672638df6b468a6f636e632c5e1a0b09e617534aaf466b1c719c6df16952aaf8a51cb2659bed1d0ef","shortMessageHtmlLink":"Merge #692: CI: Revert cc pin in ASAN job"}},{"before":"5fa3623acf0c06bd11f21d0b32912db2cd5ba146","after":"d5f8b2abffe2ad68fb1c1f722e5b7214dd164af7","ref":"refs/heads/master","pushedAt":"2024-03-27T18:34:16.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#691: Check for API changes in CI\n\n65d54e7bbeec41f2c61e61581a78758240e58dec Add script to update-lock-files (Tobin C. Harding)\nc61db1b44f690901335db479f1f85eb745102641 CI: Check for API changes (Tobin C. Harding)\n53d34d5ee0a89a4a41b17db7e3aa31d39db57d72 Update the API files (Tobin C. Harding)\nc3f2c59db1f681d3770425d5f43483901545ca78 just: Add a command to check for API changes (Tobin C. Harding)\n1e22d74270b357566ef266b790635ce6319dc569 Add a justfile (Tobin C. Harding)\n\nPull request description:\n\n This PR is not just CI, it does a few clean up chores:\n - Add a `justfile` (including command to check the API)\n - Update the API files\n - Add a script to update the lock files\n\nACKs for top commit:\n apoelstra:\n ACK 65d54e7bbeec41f2c61e61581a78758240e58dec\n\nTree-SHA512: c799200dc761cb4367904346024834caf52e9a549aed5741263429d0bd297858c5293bfdb4bdf83fffb063060f7f251c9c1956659bd50867b09fafddb3c54880","shortMessageHtmlLink":"Merge #691: Check for API changes in CI"}},{"before":"fb676dcb1f0c4b634a2ec6ea19385c40c9985300","after":"5fa3623acf0c06bd11f21d0b32912db2cd5ba146","ref":"refs/heads/master","pushedAt":"2024-03-26T22:38:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#689: Allow dead_code on AlignedType\n\n873ad47343f3dba2fd9f7f9b9944a6214e656512 Allow dead_code on AlignedType (Tobin C. Harding)\n\nPull request description:\n\n We use the `AlignedType` and take a pointer to its inner data, never access the data directly - this confuses clippy causing a \"field is never used\" warning.\n\n Shoosh the lint and add a code comment explaining why.\n\nACKs for top commit:\n apoelstra:\n ACK 873ad47343f3dba2fd9f7f9b9944a6214e656512\n\nTree-SHA512: 2a383aed169edf247def5c291bc2d8177cc09412b82bb47bb514e0929ae89d689102e646dcbbffc6fd4caa1ce1430420a63c7ceb3428ad9b05230a93b7f14d16","shortMessageHtmlLink":"Merge #689: Allow dead_code on AlignedType"}},{"before":"a1d8c90a4677321765e93bc3eeff5ec7ee88228e","after":"fb676dcb1f0c4b634a2ec6ea19385c40c9985300","ref":"refs/heads/master","pushedAt":"2024-01-31T21:32:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#678: schnorr: Change verify_schnorr error return type\n\nadee34fe18ac9bcc59b2fab4a9f57260c30619a7 schnorr: Change verify_schnorr error return type (Steven Roose)\n\nPull request description:\n\n Bumped into this.\n\nACKs for top commit:\n Kixunil:\n ACK adee34fe18ac9bcc59b2fab4a9f57260c30619a7\n tcharding:\n ACK adee34fe18ac9bcc59b2fab4a9f57260c30619a7\n apoelstra:\n ACK adee34fe18ac9bcc59b2fab4a9f57260c30619a7\n\nTree-SHA512: 7ddad93fc69e36d7d33b54526b7c108df9fc69e6153eb583a69eca840c3bd095bcabe03c32ad21577e0fe1a12f1d191d7f5b7edd722fd20ecc200a30c8ee4d25","shortMessageHtmlLink":"Merge #678: schnorr: Change verify_schnorr error return type"}},{"before":"9bc110b7d2ffbbe8653669289a6e304aad0adfff","after":"a1d8c90a4677321765e93bc3eeff5ec7ee88228e","ref":"refs/heads/master","pushedAt":"2024-01-31T14:26:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#677: bump version to 0.28.2\n\n1a162faf40d53f62076ea5865b318237effe2d61 bump version to 0.28.2 (Andrew Poelstra)\n\nPull request description:\n\n Minor version which just adds some methods to various types.\n\nACKs for top commit:\n Kixunil:\n ACK 1a162faf40d53f62076ea5865b318237effe2d61\n\nTree-SHA512: d93b1abc04d6165bf121f9385683178ada0103501a3de198772b992e2c01e8d9e742f7cd111fdaef825be4fd989d01b6928f2dece4fd78e286798ee905ce9e42","shortMessageHtmlLink":"Merge #677: bump version to 0.28.2"}},{"before":"4dede134de8a80ea615e0cf735cdf963ff5d1ed9","after":"9bc110b7d2ffbbe8653669289a6e304aad0adfff","ref":"refs/heads/master","pushedAt":"2024-01-30T18:15:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#676: Add byte accessors to `ElligatorSwiftSharedSecret`\n\n7fe89c488bfc8d2e4987ba17fd7e13dcd3bb79ba Add byte accessors to `ElligatorSwiftSharedSecret` (Martin Habovstiak)\n\nPull request description:\n\n The inner bytes of `ElligatorSwiftSharedSecret` were almost inaccessible making the type almost useless, so this commit adds methods to access inner bytes.\n\n Closes #675\n\nACKs for top commit:\n apoelstra:\n ACK 7fe89c488bfc8d2e4987ba17fd7e13dcd3bb79ba\n\nTree-SHA512: 5ec457401c83423b180f7a6f28048f93040c39129050707b981d1c113e3daa85a37b3f848e61cd3230cc26db4a783e561b77e09b766fd8193d8f7bf187214091","shortMessageHtmlLink":"Merge #676: Add byte accessors to ElligatorSwiftSharedSecret"}},{"before":"f96fcd8fcf35ee8c23c935a7432a9c65afe9285d","after":"4dede134de8a80ea615e0cf735cdf963ff5d1ed9","ref":"refs/heads/master","pushedAt":"2024-01-22T18:45:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#611: Impl Ord and PartialOrd for RecoverableSignature\n\ndbc546596f4c7b2d4d1e489aa7e91775eaf54bb0 Impl Ord and PartialOrd for RecoverableSignature (benthecarman)\n\nPull request description:\n\nACKs for top commit:\n apoelstra:\n ACK dbc546596f4c7b2d4d1e489aa7e91775eaf54bb0 oops, sorry!\n\nTree-SHA512: decda6b6e7a4929147f5ca00cb2802037c6a297aa816c253e181f1a85ec9e46958469b9d481e2b4aba2c6d86def80bba33a62c507459d82c86cfed4271a23eea","shortMessageHtmlLink":"Merge #611: Impl Ord and PartialOrd for RecoverableSignature"}},{"before":"a771f6c722e3f4aefb5190a3aa1f3024325cd1bc","after":"f96fcd8fcf35ee8c23c935a7432a9c65afe9285d","ref":"refs/heads/master","pushedAt":"2024-01-18T16:23:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#674: Derive Hash for Scalar\n\nf87dc911516219641baa604879cfb6016fb35b3c Derive Hash for Scalar (Jiri Jakes)\n\nPull request description:\n\n Unless there is some safety concern I cannot see, having Scalar implementing Hash would be useful.\n\nACKs for top commit:\n Kixunil:\n ACK f87dc911516219641baa604879cfb6016fb35b3c\n apoelstra:\n ACK f87dc911516219641baa604879cfb6016fb35b3c\n\nTree-SHA512: 276670a3d938fade3828123547b01e38b1a3c56775fb3c545d2c392622de808cf2bf8125925c7896ee27bacd5897d88908384d8c157dc8ec7d605781475964fd","shortMessageHtmlLink":"Merge #674: Derive Hash for Scalar"}},{"before":"60a5e36c14a25f756358c108b7b53fd469576e70","after":"a771f6c722e3f4aefb5190a3aa1f3024325cd1bc","ref":"refs/heads/master","pushedAt":"2024-01-03T19:58:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#672: release 0.28.1\n\n0ed5a5582976bb0ba8f4abacb76e0d4cab41693b release 0.28.1 (Andrew Poelstra)\n\nPull request description:\n\n We need a new rust-secp release to deal with the new rust-secp-sys release.\n\nACKs for top commit:\n sanket1729:\n utACK 0ed5a5582976bb0ba8f4abacb76e0d4cab41693b\n Kixunil:\n ACK 0ed5a5582976bb0ba8f4abacb76e0d4cab41693b\n\nTree-SHA512: 6d54acce52acc03d09272a20242e9a086783e471153d77d10f21bf8924595d43717fd85e8aa4a9b7075c93a04ad88404377e06ca5200b1c9b45c08c01d6f77a8","shortMessageHtmlLink":"Merge #672: release 0.28.1"}},{"before":"97dade55812765e0c6ddce44377d9ccd8d97f54b","after":"60a5e36c14a25f756358c108b7b53fd469576e70","ref":"refs/heads/master","pushedAt":"2024-01-03T19:12:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#670: fix incorrect FFI binding for pubkey_combine\n\n3373cc930eb67559d29eeb65effe0d64dd3e0152 secp256k1-sys: update all symbols from 0.9.1 to 0.9.2 (Andrew Poelstra)\n484e5d8d5b9d001af4ce5796b9837bbc704bebea fix incorrect FFI binding for pubkey_combine (Andrew Poelstra)\n\nPull request description:\n\n Fixes #669.\n\n Needs backport.\n\nACKs for top commit:\n Kixunil:\n ACK 3373cc930eb67559d29eeb65effe0d64dd3e0152\n\nTree-SHA512: 602a5baa8095cc744a341d64e300185bce26c8c56e7a538d3b17c7ca4c98cb3244217cd34169e1e69dc904a9f9f28ed75fe096ffa95ea42d1ad3456d395f7ce5","shortMessageHtmlLink":"Merge #670: fix incorrect FFI binding for pubkey_combine"}},{"before":"023d50b4dbb7edb1cd31b1a04050b17ba0733fcf","after":"97dade55812765e0c6ddce44377d9ccd8d97f54b","ref":"refs/heads/master","pushedAt":"2023-12-06T23:40:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#668: secp256k1-sys: Bump version to 0.9.1\n\nc1ccda18b68f9f5ade9ee80d100ad41f58afc94f secp256k1-sys: Bump version to 0.9.1 (Tobin C. Harding)\n\nPull request description:\n\n In preparation for doing a point release add a changelog entry, bump the version, and update all the `0_9_0` identifiers in the vendored code.\n\n Done so we can release the wasm-build bug fix.\n\n Fix: #667\n\nACKs for top commit:\n apoelstra:\n ACK c1ccda18b68f9f5ade9ee80d100ad41f58afc94f\n\nTree-SHA512: 4fda58bd2d97b73280c00f06109d4ecf913e87ecbd1e31465efe94b96589c819ffda0ae5c622428f0a7f2e09ec45033a0e683dfd954cf06369aac6b9369471c1","shortMessageHtmlLink":"Merge #668: secp256k1-sys: Bump version to 0.9.1"}},{"before":"4244fec9ad13e3f51696238b79480cd5199b9ab4","after":"023d50b4dbb7edb1cd31b1a04050b17ba0733fcf","ref":"refs/heads/master","pushedAt":"2023-11-15T18:28:12.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#663: Patch out any instances of printf in upstream\n\n7a0c60edcd976bd55abf1490aa8454ef2d1a7caf secp256k1-sys: patch out checked_malloc (Andrew Poelstra)\n942a0e5e2cf35e728dc75a7e20c68dd01c69308e build.rs: patch out any calls to `printf` (Andrew Poelstra)\n51dab7ac041aea166f3529cff44ebb5855e3a180 vendor-libsecp: remove util.h patch (Andrew Poelstra)\n\nPull request description:\n\n Rather than using a new patchfile, just `#define` it away. Also includes a commit which removes one of the existing patchfiles, which I discovered was out of date while auditing the others to see if they could be replaced by `#define`s. (No, they cannot.)\n\n Fixes #660\n\nACKs for top commit:\n tcharding:\n AFAICT this is right to go, ACK 7a0c60edcd976bd55abf1490aa8454ef2d1a7caf\n Kixunil:\n ACK 7a0c60edcd976bd55abf1490aa8454ef2d1a7caf\n\nTree-SHA512: 83ba70b000919fb8a929804c9d5929a9929b80515f0594925d3789ef896889d3c909f9fa920bac45470611607b84f509723544fa442ff1a51eefba0de75bf68f","shortMessageHtmlLink":"Merge #663: Patch out any instances of printf in upstream"}},{"before":"fb280a3179a2ee630c8ec4ea636a9885806c1f60","after":"4244fec9ad13e3f51696238b79480cd5199b9ab4","ref":"refs/heads/master","pushedAt":"2023-11-15T18:09:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#666: Remove unnecessary code comment\n\n458712212d4a2340bf3fcfc419c0636e8c2770fc Improve code comments (Tobin C. Harding)\n\nPull request description:\n\n These comments say what the code is doing, they add no value.\n\nACKs for top commit:\n Kixunil:\n ACK 458712212d4a2340bf3fcfc419c0636e8c2770fc\n apoelstra:\n ACK 458712212d4a2340bf3fcfc419c0636e8c2770fc\n\nTree-SHA512: 0f31d36d7dfbde5bf32d622c3ba1845d5c6989c3eff0e520b77eeee595453299551172331851176e50aef4f78eacb7033c0ff798077e44e1c63313013b073f0b","shortMessageHtmlLink":"Merge #666: Remove unnecessary code comment"}},{"before":"09810e7fd8babec7d6982a7199ca4c4e8a86a749","after":"fb280a3179a2ee630c8ec4ea636a9885806c1f60","ref":"refs/heads/master","pushedAt":"2023-11-03T19:33:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#664: Fix unit test import statements\n\ndd6bf7c10da707bb50a216377c47319951c27c0c Fix unit test import statements (Tobin C. Harding)\n\nPull request description:\n\n In `lib.rs` unit tests we are getting build warnings because of how we are importing things, just import with `super::*` unconditionally and be done with it.\n\n This patch is the only good one out of #661.\n\nACKs for top commit:\n apoelstra:\n ACK dd6bf7c10da707bb50a216377c47319951c27c0c\n Kixunil:\n ACK dd6bf7c10da707bb50a216377c47319951c27c0c\n\nTree-SHA512: 3970f4c1374ec6de4798bfb52b561e9ac4611ec3a3885edc79639566f777e1fbb502cb36fa7abd015f3fd4a9ca4b6a4931b4ecb2e629e967b4e49391db97a97f","shortMessageHtmlLink":"Merge #664: Fix unit test import statements"}},{"before":"fe2905d8e36e67855c201fad149b170089619a9a","after":"09810e7fd8babec7d6982a7199ca4c4e8a86a749","ref":"refs/heads/master","pushedAt":"2023-11-02T11:53:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#659: Implement `Ord` for `SerializedSignature`\n\ne55c1f0960a7ede1e2f33831119c6e9361d55e90 Implement `Ord` for `SerializedSignature` (Martin Habovstiak)\n\nPull request description:\n\nACKs for top commit:\n tcharding:\n ACK e55c1f0960a7ede1e2f33831119c6e9361d55e90\n apoelstra:\n ACK e55c1f0960a7ede1e2f33831119c6e9361d55e90\n\nTree-SHA512: b9a7529f44e5d38ab449af7ee06007f3d0480b31cb21c371190f71bea4e3d9142c6c249fcc5564aa21139c0bdcd3951823cea70f29a63f3ef6d35b7e9c7a8e8c","shortMessageHtmlLink":"Merge #659: Implement Ord for SerializedSignature"}},{"before":"902150cc7caf75e96d4715b797eac919d51e8bb7","after":"fe2905d8e36e67855c201fad149b170089619a9a","ref":"refs/heads/master","pushedAt":"2023-10-31T15:12:37.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#658: Serialized signture improvements\n\n62c839c9e03b5cacb7da34aecff6eefc29f8f293 Implement conversion traits (Martin Habovstiak)\ndc3eab7aaa7082be4d598edc5a1e511f5f976a38 Implement `Borrow<[u8]>`, `PartialEq<[u8]>`, `Hash` (Martin Habovstiak)\n7dac91d973b4fc97e2ca2d0d894b46ec3e686ff3 Deprecate `capacity` and `is_empty` (Martin Habovstiak)\n\nPull request description:\n\n This deprecates methods returning constants and impls a few traits.\n\nACKs for top commit:\n apoelstra:\n ACK 62c839c9e03b5cacb7da34aecff6eefc29f8f293\n\nTree-SHA512: 724a08af7dc915e166e3efcdc4be681a53ae14a55d9cbd62dd4c5240fa8c0f13110498d03ebb0edc1d56f969901f978aa33bae9df19376957ff7f51698ed9535","shortMessageHtmlLink":"Merge #658: Serialized signture improvements"}},{"before":"7de09c8050da12a13ef9ee3850597f69c887952d","after":"902150cc7caf75e96d4715b797eac919d51e8bb7","ref":"refs/heads/master","pushedAt":"2023-10-26T14:21:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#656: Check for changes to the public API\n\ne9e17a00393bad3db5d8d8654eb1f4bf1f20cbbb Check for changes to the public API (Tobin C. Harding)\n\nPull request description:\n\n We would like to get to a stage where we can commit to the public API. To help us achieve this add a script that generates the public API and checks it against three committed files, one for each feature set: no features, alloc, std.\n\n The idea is that with this applied any PR that changes the public API should include a final patch that is just the changes to the api/*.txt files, that way reviewers can discuss the changes without even needing to look at the code, quickly giving concept ACK/NACKs. We also run the script in CI to make sure we have not accidentally changed the public API so that we can be confident that don't break semver during releases. The script can also be used to diff between two release versions to get a complete list of API changes, useful for writing release notes and for users upgrading.\n\n There is a development burden involved if we apply this patch.\n\nACKs for top commit:\n apoelstra:\n ACK e9e17a00393bad3db5d8d8654eb1f4bf1f20cbbb\n\nTree-SHA512: 94a2cedb132db457b67b3c60cde8843d9db1d2bc8dba0530cd5c518ebed955bd66a1649c61e0cb96b6f293ce6b9b0395582877ce9f1de003e0020a66100d172f","shortMessageHtmlLink":"Merge #656: Check for changes to the public API"}},{"before":"3aada83180beec2b9f5ab8e7b9280a5517d3bcde","after":"7de09c8050da12a13ef9ee3850597f69c887952d","ref":"refs/heads/master","pushedAt":"2023-10-09T22:53:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#650: Tracking PR for release: `secp256k1 v0.28.0` and `secp256k-sys 0.10.0`\n\n3dc5b165401f249c01a88cec54061301cffd97a0 Bump version to v0.28.0 (Tobin C. Harding)\n\nPull request description:\n\n Bump the version of `secp256k1` ready for release.\n\n Includes changelog for the already-bumped `secp256k1-sys`, changelog for `secp256k1`, and the version bump for `secp256k1`.\n\nACKs for top commit:\n apoelstra:\n ACK 3dc5b165401f249c01a88cec54061301cffd97a0\n\nTree-SHA512: 404a5512f7bb245cde12d11eb20f2e7bedfa5a8d4124101e04bf51010301fe7d186c3baedf8744006d1c56c0af1bf214f0226c71a54dc6677384ecc8dcc8fde0","shortMessageHtmlLink":"Merge #650: Tracking PR for release: secp256k1 v0.28.0 and `secp256…"}},{"before":"da4f67b274c3061717723a568cfb182e4e2e7cce","after":"3aada83180beec2b9f5ab8e7b9280a5517d3bcde","ref":"refs/heads/master","pushedAt":"2023-10-09T21:26:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#627: Add bindings to the ElligatorSwift implementation\n\n39febcb866ce285d53052a3636602f04483aa710 Create rust-bidings (Davidson Souza)\n\nPull request description:\n\n ~**Marking as draft as this is an unreleased feature from libsecp**~\n\n From upstream:\n This implements encoding of curve points using the ElligatorSwift algorithm, using 4 new API calls:\n\n secp256k1_ellswift_encode, which converts a public key to a 64-byte pseudorandom encoding.\n secp256k1_ellswift_decode, the reverse operation to convert back to normal public keys.\n secp256k1_ellswift_create, which can be seen as a combination of secp256k1_ec_pubkey_create + secp256k1_ellswift_encode, but is somewhat safer.\n secp256k1_ellswift_xdh, which implements x-only Diffie-Hellman directly on top of 64-byte encoded public keys, and more efficiently than decoding + invoking normal ECDH.\n\n This algorithm allows mapping any pair of field elements (u, t) to a (valid) x coordinate in the curve. This allows representing a field element as a 64-bytes bit string that is indistinguishable from random. You can build a pair of (u, t) from any group element as well.\n We also have an integrated x-only ECDH that can be used to establish a shared secret between two parties. All algorithms are compatible with BIP324 and are tested against the BIP's test cases.\n\n I have a few questions about the rust side of the implementation:\n Should it be always on, or leave it behind a cargo feature? In `libsecp` this module is default on, but you can disable it.\n I'm not exposing the low-level functions, instead you can use high-level types to interact with ellswift. Is it reasonable to also expose a safe version of the functions above?\n\nACKs for top commit:\n tcharding:\n ACK 39febcb866ce285d53052a3636602f04483aa710\n apoelstra:\n ACK 39febcb866ce285d53052a3636602f04483aa710\n\nTree-SHA512: a3c06304a03af9509ff3ef16fd39ee56ec22fc12d1b36be4c20aaa2ad01e98dd34ea64c66db782d3a2c10c3a7b44c701762d45f8d82f45b62db3379710c89c42","shortMessageHtmlLink":"Merge #627: Add bindings to the ElligatorSwift implementation"}},{"before":"302ff20b3da25ffc5553d768873a9bc8fc4d9e30","after":"da4f67b274c3061717723a568cfb182e4e2e7cce","ref":"refs/heads/master","pushedAt":"2023-09-30T17:43:25.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#653: Update vendored lib secp256k1 to v0.4.0\n\n80b2a8d4aa6ffa72041d569eab2278cd8c1ace2a Update vendored libsecp to v0.4.0 (Davidson Souza)\nd2285c929a086276ce6d1670d795c49191e30c65 ci: Remove MIPS* from CI (Davidson Souza)\n0d58f50d523b40a78de0b87146208e3ad338c8ba ci: generalize grp in \"illegal callback\" test (Andrew Poelstra)\nacf9ac13e9f8df84dd52d2f012cda7211a6af10c delete `test_manual_create_destroy` test (Andrew Poelstra)\n04ce50891bb0d49be5355f5c0d82db70d7dda65a lib: fix bad unit test (Andrew Poelstra)\ne4cca901ead00a8a7ca5746523aeec277cb00259 gitignore: remove things that shouldn't be there (Andrew Poelstra)\n\nPull request description:\n\n Replaces #645 and #652. Precedes #627.\n\n I'm basically using #652 but resolving the linking problems,\n\n My local CI is erring on windows cross-test, but I can compile without issue with `cargo build --target x86_64-pc-windows-gnu`. Some MIPS jobs failed before even installing cross, I think those aren't really related to this PR. Any ideas on what can be happening?\n\nACKs for top commit:\n apoelstra:\n ACK 80b2a8d4aa6ffa72041d569eab2278cd8c1ace2a\n\nTree-SHA512: 62c2e04348110e3995111fa666f10dcc403b963770d047361f9209cf45b45db8744a7eb6d9ee3278d18007412dab5131ac3e1dd3e3d704963c6a6f232d57199a","shortMessageHtmlLink":"Merge #653: Update vendored lib secp256k1 to v0.4.0"}},{"before":"83a22455823707c827bf9887d5346936d545e43e","after":"302ff20b3da25ffc5553d768873a9bc8fc4d9e30","ref":"refs/heads/master","pushedAt":"2023-08-26T16:21:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#649: Use range dependency for hashes v0.12.0 - v0.13.0\n\n936421476eedd784d40ba6187fd044a7c9208439 Use range dependency for hashes v0.12.0 - v0.13.0 (Tobin C. Harding)\n\nPull request description:\n\n There are zero code changes required to support v.0.13.0 so we elect to use a range dependency to make the upgrade path for downstream users more pleasant.\n\n Upgrade the dependency of `hashes` to be either v0.12.0 or v0.13.0\n\n Use v0.13.0 in the recent/minimal lockfiles.\n\nACKs for top commit:\n apoelstra:\n ACK 936421476eedd784d40ba6187fd044a7c9208439\n\nTree-SHA512: c411acbd6025a751920fe2c432bf8c9ab78e891a3b32170f85873732c595777e075bd8b1277bf7b156e941a3caf532af71af36e99f88aa36dadbd66c61384166","shortMessageHtmlLink":"Merge #649: Use range dependency for hashes v0.12.0 - v0.13.0"}},{"before":"d9aadc6eaa9e7f303377d88bedcb7cd63904aaf0","after":"83a22455823707c827bf9887d5346936d545e43e","ref":"refs/heads/master","pushedAt":"2023-08-20T14:04:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#643: Update docs to mention ECDSA\n\naa4489c71b3ae4acd7cbab9755caf8348e2ade5e key: Improve docs (Tobin C. Harding)\n\nPull request description:\n\n `PublicKey` types are for verifying ECDSA signatures, when these docs where written there were no other types of signatures. With the addition of taproot these docs have become stale.\n\nACKs for top commit:\n apoelstra:\n ACK aa4489c71b3ae4acd7cbab9755caf8348e2ade5e\n\nTree-SHA512: bb24d82f2bf316f8907b1bf02132d454d21f0b13d57f06f09f9985bc7fbf7b36e6972a0fdaf3a68967577dbe1995f2a14fd06fddd38eb46718f04bca1c50a445","shortMessageHtmlLink":"Merge #643: Update docs to mention ECDSA"}},{"before":"1f9c01af1874afacfb867882bd6ad3d9815acf98","after":"d9aadc6eaa9e7f303377d88bedcb7cd63904aaf0","ref":"refs/heads/master","pushedAt":"2023-08-20T14:02:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#648: Rename KeyPair to Keypair\n\n33747bb16f05c98fbc7a6a9df3a9ea8eafe68c0b Rename KeyPair to Keypair (Tobin C. Harding)\n\nPull request description:\n\n We use \"keypair\" in identifiers (local vars and function names) but `KeyPair` - one of them is wrong.\n\n Elect to follow upstream and define keypair as a single word i.e., use `Keypair` for type name and `keypair` in identifiers.\n\n This patch can be reproduced mechanically by doing two search-and-replace operations on all files excluding the CHANGELOG\n\n - Replace \"KeyPair\" with \"Keypair\"\n - Replace \"key_pair\" with \"keypair\"\n\n Fix #647\n\nACKs for top commit:\n apoelstra:\n ACK 33747bb16f05c98fbc7a6a9df3a9ea8eafe68c0b\n\nTree-SHA512: 2cb67cde3a39c4681e0628b17b12724fe17d00bc71e985b4eb0b3ad58d574f4a372aa782fc9cb7221cd2032d8312c579195ad2230a3eeb4c550865fa36e42c0b","shortMessageHtmlLink":"Merge #648: Rename KeyPair to Keypair"}},{"before":"70585395c38a60a881b73689082b5473a1c84758","after":"1f9c01af1874afacfb867882bd6ad3d9815acf98","ref":"refs/heads/master","pushedAt":"2023-08-15T16:54:44.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-secp256k1#628: Clean up the hashes dependency/feature\n\n6fdd3b1da518e828545dcec54340f9ea6f81c741 Clean up hashes import statements (Tobin C. Harding)\n6d7c653b64a48aa80486f87907418992dd63d49b Use hashes instead of bitcoin_hashes (Tobin C. Harding)\n\nPull request description:\n\n Use the more terse `hashes` by way of the `package` field in the manifest.\n\n Allows us to remove the ugly feature alias \"bitcoin-hashes\" -> \"bitcoin_hashes\" and removes all the bother with the underscore.\n\nACKs for top commit:\n apoelstra:\n ACK 6fdd3b1da518e828545dcec54340f9ea6f81c741\n\nTree-SHA512: 2c6c81b6ef900bfe930df48ddd32e795997c107a2a94b9e2ea014da0be7aefaa952e1259ddb570b30f5ad7e94c0a9443b691645cb386a8d0349dc7a81f659ed6","shortMessageHtmlLink":"Merge #628: Clean up the hashes dependency/feature"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEJgKAvwA","startCursor":null,"endCursor":null}},"title":"Activity · rust-bitcoin/rust-secp256k1"}