Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Deprecate concolor #47

Open
epage opened this issue Jun 8, 2023 · 2 comments
Open

Deprecate concolor #47

epage opened this issue Jun 8, 2023 · 2 comments

Comments

@epage
Copy link
Contributor

epage commented Jun 8, 2023

concolor was intended as a way to be aware of the exact color situation for either stdout or stderr anywhere in an application, whether from environment detection or the command-line.

Through the time I've been using concolor, I've been feeling like this direction is a mistake. We instead need to be encouraging decoupling of rendering code from color control. To this end, I've created anstream which has been used in clap now for about three months.

For applications where anstream doesn't work, I feel like users would be better off composing what they need out of colorchoice, colorchoice-clap, and your choice of environment detection crates including anstyle-query and supports-color.

As I feel like both of these are a better route and that should cover all users, I don't see how concolor fits into the CLI story anymore and propose we deprecate it.

If nothing comes up before then, we'll likely archive the repo in about a month

@max-sixty
Copy link

Thanks @epage. We're happy to take your direction. We're mostly consumers of colors through Ariadne so would likely follow what @zesterer does.

(I coincidentally looked at how we were handling colors in PRQL/prql#2755 & zesterer/ariadne#79; possibly this displaces those)

@max-sixty
Copy link

We've now removed concolor is favor of anstream & colorchoice-clap PRQL/prql#2773

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants