add .duplicates() and .duplicates_by(..) operations #502
+290
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
force-pushed
the
duplicate-iter
branch
from
3944a97 to
929f36d
Compare
phimuemue
reviewed
Dec 4, 2020
petrosagg
force-pushed
the
duplicate-iter
branch
from
929f36d to
88072e8
Compare
jswrenn
reviewed
Jan 18, 2021
petrosagg
force-pushed
the
duplicate-iter
branch
from
88072e8 to
e822ec3
Compare
|
@jswrenn thanks for taking another look. I just rebased on top of master and I'm happy to resolve the naming as you see fit :) |
petrosagg
force-pushed
the
duplicate-iter
branch
from
e822ec3 to
58940ea
Compare
|
@jswrenn should be good to merge now :) |
petrosagg
changed the title
petrosagg
changed the title
jswrenn
reviewed
Jan 18, 2021
petrosagg
force-pushed
the
duplicate-iter
branch
2 times, most recently
from
30f749d to
5a620b8
Compare
jswrenn
requested changes
Jan 20, 2021
petrosagg
force-pushed
the
duplicate-iter
branch
from
5a620b8 to
e035b58
Compare
Uses a HashMap to detect duplicates in an iterator and emits them only once. Items are never cloned. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
duplicate-iter
branch
from
e035b58 to
e1090aa
Compare
jswrenn
approved these changes
Jan 21, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a HashMap to detect duplicates in an iterator and emits them only once. The implemention is similar to the
unique()andunique_by()methods but in this case the items are never cloned.