Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize features #760

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Minimize features #760

merged 2 commits into from
Sep 29, 2023

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Sep 23, 2023 •
edited

Somehow, I looked at try_collect and ticked seeing that it needs use_alloc. It sure does in most common cases but we can collect to arrayvec for example.
Because of that, I looked at each adaptor/method to find another unrequired features and found only the ones based on extrema_set which only needs to allocate to vectors.

@Philippe-Cholet
try_collect without use_alloc
c46f78d 
We can want to collect to a stack-based structure such as `arrayvec`.
@Philippe-Cholet
extrema_set only needs alloc
de16335
@Philippe-Cholet
Copy link
Member Author

Philippe-Cholet commented Sep 29, 2023 •
edited

@jswrenn This seems straightforward to me. What do you think?
I guess I'm reserved about expanding try_collect usage (to "no std") because of the nightly version in core.
But I don't see any problem about the "extrema_set" methods.

jswrenn
jswrenn approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jswrenn jswrenn added this pull request to the merge queue Sep 29, 2023
@jswrenn jswrenn added this to the next milestone Sep 29, 2023
Merged via the queue into rust-itertools:master with commit 2ec463c Sep 29, 2023
8 checks passed
@Philippe-Cholet Philippe-Cholet deleted the minimize-features branch September 29, 2023 11:54
@jswrenn jswrenn mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Philippe-Cholet @jswrenn