Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unaligned display when one line source given #57

Open
tisonkun opened this issue Jun 23, 2023 · 2 comments
Open

Unaligned display when one line source given #57

tisonkun opened this issue Jun 23, 2023 · 2 comments
Labels
C-bug Category: bug

Comments

@tisonkun
Copy link

Result:

 |
0 | SELECT bar
 |        ^^^ unexpected token
 | ^^^^^^^^^^ while parsing statement
 |

As you can see the | is not aligned.

Code:

pub(crate) fn display_annotated_error(source: &str, labels: Vec<(Range, String)>) -> String {
    let annotations = labels
        .iter()
        .map(|label| SourceAnnotation {
            range: (label.0.start, label.0.end),
            label: label.1.as_str(),
            annotation_type: AnnotationType::Error,
        })
        .collect::<Vec<_>>();

    let snippet = Snippet {
        title: None,
        footer: vec![],
        slices: vec![Slice {
            source,
            line_start: 0,
            origin: None,
            annotations,
            fold: false,
        }],
        opt: FormatOptions {
            color: true,
            ..Default::default()
        },
    };

    format!("{}", DisplayList::from(snippet))
}

display_annotated_error("SELECT bar", labels)
// where labels = [((7, 10), unexpected token), ((0, 10), while parsing statement)],
@tisonkun
Copy link
Author

... while change source to SELECT \nbar gives a proper formatted:

  |
0 | / SELECT 
1 |   bar
  | | ^^^ unexpected token
  | |___^ while parsing statement
  |

@tisonkun
Copy link
Author

Change line_start to 1 also fix the issue. Perhaps it's a bug for line_start == 0.

@epage epage added the C-bug Category: bug label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants