Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MAPPINGS_CACHE_SIZE configurable #499

Open
hehechen opened this issue Dec 1, 2022 · 0 comments
Open

Make MAPPINGS_CACHE_SIZE configurable #499

hehechen opened this issue Dec 1, 2022 · 0 comments
Labels
enhancement

Comments

@hehechen
Copy link

hehechen commented Dec 1, 2022 •
edited

The MAPPINGS_CACHE_SIZE is 4 by hard coding.
Can we make it configurable? In some scenarios, the lib mappings cache miss will cause performance degrade, especially in the scenario that the debug sections are compressed. For example: pingcap/tiflash#6347 (comment)
Some users may want to increase MAPPINGS_CACHE_SIZE to trade memory for performance improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@hehechen @workingjubilee