New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix fetch of PR fork commits in binary size check workflow #544

Merged

workingjubilee merged 1 commit into rust-lang:master from Kobzol:ci-size-workflow-fix

Jul 6, 2023

Contributor

Kobzol commented Jul 6, 2023

Probably not all PRs to this repo will come from my fork, specifically.


          CI: fix fetch of PR fork commits in binary size check workflow

06f3ff4

workingjubilee approved these changes

View reviewed changes

.github/workflows/check-binary-size.yml

    
            @@ -33,7 +33,7 @@ jobs:
          
                      run: |

                        printf "[llvm]\ndownload-ci-llvm = true\n\n[rust]\nincremental = false\n" > config.toml

                        cd library/backtrace

                        git remote add kobzol https://github.com/kobzol/backtrace-rs

                        git remote add head-pr https://github.com/${{ github.event.pull_request.head.repo.full_name }}

Contributor

workingjubilee Jul 6, 2023

...Impressive. I don't know why I missed this.

workingjubilee merged commit 3ad43df into rust-lang:master

35 checks passed

Kobzol deleted the ci-size-workflow-fix branch

July 6, 2023 09:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment