Update bitcode TODO #769
Merged
Update bitcode TODO #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Xcode 14 Bitcode is deprecated but Apple still accepts apps built with bitcode if you're still using Xcode 13. Once Apple stops allowing you to upload apps built with Xcode 13 this argument should be removed. rust-lang#768
|
FWIW my rust foundation grant covers fixing/improving this (and related outstanding cc-rs issues on apple targets). I'm pretty sure we can solve this one with a bit more intelligence around what sdk version is in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Xcode 14 Bitcode is deprecated but Apple still accepts apps built with bitcode if you're still using Xcode 13. Once Apple stops allowing you to upload apps built with Xcode 13 this argument should be removed.
#768