Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc-shim, apply clippy warning & optimizations to it #777

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Fix gcc-shim, apply clippy warning & optimizations to it #777

merged 1 commit into from
Jan 27, 2023

Conversation

NobodyXu
Copy link
Collaborator

Extracted from #775

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu
Fix gcc-shim, apply clippy warning & optimizations for it
c87b883 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu changed the title Fix gcc-shim, apply clippy warning & optimizations for it Fix gcc-shim, apply clippy warning & optimizations to it Jan 26, 2023
thomcc
thomcc approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I kind of think eventually we should remove this binary target (moving it to something more explicitly test-only) but I think that should be done later.

@thomcc thomcc merged commit 7575f2f into rust-lang:main Jan 27, 2023
@NobodyXu NobodyXu deleted the fix/gcc-shim branch January 28, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @thomcc