Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/flate2-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.32
Choose a base ref
...
head repository: rust-lang/flate2-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.33
Choose a head ref
  • 8 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 23, 2024

  1. Fix msrv: Run msrv checks with minimal versions 

    Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by flate2.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.

This would have also help discover bugs in #424
    @NobodyXu
    NobodyXu committed Aug 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    387b9c6 View commit details

  2. Run msrv CI on windows and macos

    @NobodyXu
    NobodyXu authored Aug 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f51da32 View commit details

  3. Run msrv with different features

    @NobodyXu
    NobodyXu authored Aug 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b332bac View commit details

  4. Do not check msrv for feature zlib-rs

    @NobodyXu
    NobodyXu authored Aug 23, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    80fc1e5 View commit details

Commits on Aug 24, 2024

  1. increase minimal versions of libz-ng-sys and libz-sys to their la… 

    …test releases.

That way, those compiling with `-Zminimal-versions` have higher chances of it to work.

See GitoxideLabs/gitoxide#1541 for reference.
    @Byron
    Byron committed Aug 24, 2024
    Copy the full SHA
    a5d38e8 View commit details

  2. bump patch level for new release that builds with -Zminimal-versions

    @Byron
    Byron committed Aug 24, 2024
    Copy the full SHA
    66c6907 View commit details

  3. bump *tested* MSRV to 1.63 

    That way it should compile with minimal versions.

Reason for this is the following:

````
error: package `cc v1.0.98` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.56.1
````

Note that the expressed MSRV is still a lower one as it may work for
some people that use different settings and/or configuration.
    @Byron
    Byron committed Aug 24, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    a2df1db View commit details

  4. Merge pull request #425 from NobodyXu/patch-1 

    Fix msrv: Run msrv checks with minimal versions
    @Byron
    Byron authored Aug 24, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    50852c6 View commit details
Showing with 18 additions and 6 deletions.
  1. +15 −3 .github/workflows/main.yml
  2. +3 −3 Cargo.toml
18 changes: 15 additions & 3 deletions .github/workflows/main.yml
View file
Original file line number Diff line number Diff line change
@@ -77,13 +77,25 @@ jobs:

minimum:
name: Minimum Rust compiler
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [windows-2022, macos-latest, ubuntu-latest]
env:
# If this is changed to pass tests, then set `rust-version` in `Cargo.toml` to the same version.
version: 1.56.1
version: 1.63.0
steps:
- uses: actions/checkout@v4
- name: Install Rust (rustup)
run: rustup update ${version} --no-self-update && rustup default ${version}
run: |
rustup toolchain install ${version} nightly --profile minimal --no-self-update
rustup default ${version}
cargo +nightly update -Zminimal-versions
shell: bash
- run: cargo build
- run: cargo build --features zlib
- run: cargo build --features zlib --no-default-features
- run: cargo build --features zlib-default --no-default-features
- run: cargo build --features zlib-ng-compat --no-default-features
- run: cargo build --features zlib-ng --no-default-features
- run: cargo build --features cloudflare_zlib --no-default-features
6 changes: 3 additions & 3 deletions Cargo.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "flate2"
authors = ["Alex Crichton <alex@alexcrichton.com>", "Josh Triplett <josh@joshtriplett.org>"]
version = "1.0.32"
version = "1.0.33"
edition = "2018"
license = "MIT OR Apache-2.0"
readme = "README.md"
@@ -19,8 +19,8 @@ and raw deflate streams.
exclude = [".*"]

[dependencies]
libz-sys = { version = "1.1.8", optional = true, default-features = false }
libz-ng-sys = { version = "1.1.8", optional = true }
libz-sys = { version = "1.1.20", optional = true, default-features = false }
libz-ng-sys = { version = "1.1.16", optional = true }
libz-rs-sys = { version = "0.2.1", optional = true, default-features = false, features = ["std", "rust-allocator"] }
cloudflare-zlib-sys = { version = "0.3.0", optional = true }
miniz_oxide = { version = "0.8.0", optional = true, default-features = false, features = ["with-alloc"] }