Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryFlattenUnordered #2577

Merged
merged 11 commits into from Apr 16, 2022
Merged

TryFlattenUnordered #2577

merged 11 commits into from Apr 16, 2022

Conversation

olegnn
Copy link
Contributor

@olegnn olegnn commented Mar 12, 2022 •
edited

  • Basic TryFlattenUnordered implementation atop of FlattenUnordered.
  • Improve the FlattenUnordered interface by removing the Unpin requirement for Self::Item. This's much more convenient and I guess it's a good choice for simplification despite a possibly unneeded Pin<Box<_>>.
  • FusedStream impl for FlattenUnordered: remove unneeded Self::Item: FusedStream requirement.
  • Minor improvement of the FlattenUnordered internal logic.
  • Export all underlying types.
  • Docs improvements.

@olegnn olegnn requested a review from taiki-e as a code owner March 12, 2022 18:41
@olegnn olegnn force-pushed the try-flatten-unordered branch 3 times, most recently from 969a247 to a91df12 Compare March 13, 2022 13:32
@olegnn olegnn force-pushed the try-flatten-unordered branch 2 times, most recently from ba42829 to d1f6c18 Compare March 13, 2022 14:07
@taiki-e taiki-e added the A-stream Area: futures::stream label Mar 18, 2022
@olegnn olegnn requested a review from taiki-e March 21, 2022 14:44
@olegnn olegnn changed the title TryFlattenUnordered + improve FlattenUnordered TryFlattenUnordered Mar 21, 2022
taiki-e
taiki-e approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label Apr 16, 2022
@taiki-e taiki-e merged commit 7549e90 into rust-lang:master Apr 16, 2022
olegnn added a commit to olegnn/futures-rs that referenced this pull request Mar 11, 2023
@olegnn
Add TryFlattenUnordered and improve FlattenUnordered (rust-lang#2577
77ba20b 
)
taiki-e pushed a commit that referenced this pull request Mar 11, 2023
@olegnn @taiki-e
Add TryFlattenUnordered and improve FlattenUnordered (#2577)
a1d09a1
@taiki-e taiki-e removed the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label Mar 11, 2023
@taiki-e taiki-e mentioned this pull request Mar 11, 2023
Merged
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 15, 2023
Update Rust crate futures to 0.3.27 (#1816)
fb4122c 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.26` -> `0.3.27` |

---

### Release Notes

<details>
<summary>rust-lang/futures-rs</summary>

### [`v0.3.27`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&#8203;0327---2023-03-11)

[Compare Source](rust-lang/futures-rs@0.3.26...0.3.27)

-   Add `TryFlattenUnordered` ([#&#8203;2577](rust-lang/futures-rs#2577), [#&#8203;2590](rust-lang/futures-rs#2590), [#&#8203;2606](rust-lang/futures-rs#2606), [#&#8203;2607](rust-lang/futures-rs#2607))
-   Add `AbortHandle::is_aborted` ([#&#8203;2710](rust-lang/futures-rs#2710))
-   Add `AbortRegistration::handle` ([#&#8203;2712](rust-lang/futures-rs#2712))
-   Make `BiLock` strict-provenance compatible ([#&#8203;2716](rust-lang/futures-rs#2716))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNS42LjAifQ==-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1816
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@tamird tamird mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olegnn @taiki-e