Provide default hasher types to Vacant and Occupied entries
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For code which may select to use the `std` `HashMap` or the `hashbrown` `HashMap` based on feature or cfg flags, being forced to provide an explicit hash argument to `VacantEntry` or `OccupiedEntry` structs requires jumping through some hoops. Specifically, the `std` `hash_map::*Entry` structs don't take a hasher type argument at all, making the downstream code change the type entirely when switching from `std` to `hashbrown` or back. For simplicity, its nice to have the argument be optional on the `hashbrown` end, which would let the same code compile with either map.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code which may select to use the
stdHashMapor thehashbrownHashMapbased on feature or cfg flags, being forced to provide an explicit hash argument toVacantEntryorOccupiedEntrystructs requires jumping through some hoops. Specifically, thestdhash_map::*Entrystructs don't take a hasher type argument at all, making the downstream code change the type entirely when switching fromstdtohashbrownor back.For simplicity, its nice to have the argument be optional on the
hashbrownend, which would let the same code compile with either map.