Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crate version to 0.2.152 #3546

Closed
wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

Could I bother you a bit more to also publish a new version of libc please? :)

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2024

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

JohnTitor commented Jan 18, 2024

Sorry but you have to send a PR against the libc-0.2 branch (changing on GitHub UI would contain other changes unfortunately), the main branch now contains breaking changes for 0.3, see https://github.com/rust-lang/libc#v03-roadmap.

@JohnTitor JohnTitor changed the base branch from main to libc-0.2 January 18, 2024 19:06
@JohnTitor JohnTitor changed the base branch from libc-0.2 to main January 18, 2024 19:06
@GuillaumeGomez
Copy link
Member Author

Ah indeed. Thanks for changing the base branch!

@JohnTitor
Copy link
Member

JohnTitor commented Jan 22, 2024

I might be unclear but you need to recreate a PR as changing the base branch on GitHub UI would contain unrelated changes :(
And if you want to ship #3536 for example, you have to submit the same PR to the libc-0.2 branch too (the main branch is now completely for v0.3)!

@GuillaumeGomez
Copy link
Member Author

Indeed I misunderstood. Sending the PRs.

@GuillaumeGomez GuillaumeGomez deleted the update-version branch January 22, 2024 12:34
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
Backport of #3546 and update crate version to 0.2.153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants