Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone installation instructions doesn't have links for other rustup components #467

Open
jyn514 opened this issue Oct 29, 2020 · 2 comments
Labels
T-infra Team: infrastructure

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 29, 2020

https://forge.rust-lang.org/infra/other-installation-methods.html#standalone, https://static.rust-lang.org/dist/rust-std-1.47.0-armv7-unknown-linux-gnueabi.tar.xz. It looks like this is generated by

for target in &self.rustup {
, but I can't see where rustup is populated.

@jyn514
Copy link
Member Author

jyn514 commented Oct 29, 2020

Looks like it comes from https://raw.githubusercontent.com/rust-lang/rustup.rs/stable/ci/cloudfront-invalidation.txt, which is also missing that target.

@pietroalbini
Copy link
Member

No, this is due to another part of the source code.

for &channel_name in CHANNELS {
let channel_url = format!("{}{}.toml", CHANNEL_URL_PREFIX, channel_name);
let content = reqwest::blocking::get(&channel_url)?.text()?;
let rust = toml::from_str::<crate::channel::Channel>(&content)?
.pkg
.rust;
log::info!(
"Found {} targets for {} channel (v{})",
rust.target.len(),
channel_name,
rust.version
);
let vers = rust.version.split(' ').next().unwrap().to_string();
let platforms = rust
.target
.into_iter()
.filter_map(|(target, content)| {
if content.available {
Some(target)
} else {
None
}
})
.collect::<Vec<_>>();
if channel_name == "stable" {
blacksmith.stable_version = Some(vers.clone());
}
for platform in platforms {
let entry = blacksmith
.platforms
.entry(platform)
.or_insert_with(Platform::default);
match channel_name {
"stable" => entry.stable = Some(vers.clone()),
"beta" => entry.beta = true,
"nightly" => entry.nightly = true,
_ => unreachable!(),
}
}
}

This generates the list of platforms with the rust component available (due to the .pkg.rust), which only catches platforms with a full host compiler. We'd need to create a separate list with the links to the rust-std components.

@ehuss ehuss changed the title Installation instructions are missing armv7-unknown-linux-gnueabi, but it exists Standalone installation instructions doesn't have links for other rustup components Oct 26, 2023
@ehuss ehuss added the T-infra Team: infrastructure label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-infra Team: infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants