Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Archive of Rust Stable Standalone Installers #733

Merged
merged 1 commit into from
May 27, 2024
Merged

Add Archive of Rust Stable Standalone Installers #733

merged 1 commit into from
May 27, 2024

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Mar 22, 2024

Closes #676

This PR adds a new page "Archive of Rust Stable Standalone Installers" that contains a list of tables of previous stable Rust version standalone installers.

Currently it works for all versions > 1.8. Versions <= 1.7 do not have v2 toml manifests. See Zulip for details.

@shepmaster @ojeda Is this what you had in mind?

Screenshots:

Screenshot 2024-03-22 at 3 33 08 AM Screenshot 2024-03-22 at 3 33 41 AM

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2024
@yerke
Copy link
Contributor Author

yerke commented Mar 22, 2024

r? @shepmaster

@rustbot rustbot assigned shepmaster and unassigned ehuss Mar 22, 2024
@yerke yerke mentioned this pull request Mar 22, 2024
Closed
@yerke yerke force-pushed the yerke/old-stable-standalone-installers branch from 1cb6b77 to db4255e Compare March 22, 2024 10:57
@ojeda ojeda mentioned this pull request Mar 22, 2024
Open
2 tasks
ehuss
ehuss reviewed Mar 23, 2024
View reviewed changes
blacksmith/src/lib.rs Show resolved Hide resolved
src/infra/archive-stable-version-installers.md Outdated Show resolved Hide resolved
@yerke yerke force-pushed the yerke/old-stable-standalone-installers branch from 6f58568 to c848983 Compare April 10, 2024 05:51
@yerke
Copy link
Contributor Author

yerke commented Apr 10, 2024

r? @ehuss

@rustbot rustbot assigned ehuss and unassigned shepmaster Apr 10, 2024
@yerke
Copy link
Contributor Author

yerke commented Apr 10, 2024

@ehuss thanks a lot for taking a look. I addressed your feedback.

@yerke yerke requested a review from ehuss April 10, 2024 05:58
@ojeda
Copy link

ojeda commented Apr 10, 2024

@shepmaster @ojeda Is this what you had in mind?

Yeah, thanks a lot!

It could be nice to have a matrix instead (but that makes it complex, i.e. empty cases would need to be handled, plus it may be not great scrolling horizontally, so it could require breaking the table in several anyway), or a selector, or at least a way to jump quickly to the right version.

But I would not worry about any of that -- even if it is just a dump of links, it is useful :)

@ehuss
Copy link
Contributor

ehuss commented Apr 10, 2024

I am not on the infra or release teams, so I'm not sure I am the appropriate person to be approving things on their behalf. Perhaps @Mark-Simulacrum would give the green light. I'm fine with the implementation barring #733 (comment) getting resolved.

Mark-Simulacrum
Mark-Simulacrum reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me with one implementation and one wording note.

blacksmith/src/lib.rs Outdated Show resolved Hide resolved
src/infra/archive-stable-version-installers.md Outdated Show resolved Hide resolved
@yerke yerke force-pushed the yerke/old-stable-standalone-installers branch from c848983 to 3dbcfd5 Compare May 5, 2024 00:23
@yerke yerke requested a review from Mark-Simulacrum May 5, 2024 00:28
@yerke
Copy link
Contributor Author

yerke commented May 5, 2024

@Mark-Simulacrum Do you mind taking another look when you get a chance? Thanks.

@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2024

Could you remove the merge commits please?

@yerke yerke force-pushed the yerke/old-stable-standalone-installers branch from ab13eed to 771066c Compare May 27, 2024 06:29
@yerke
Copy link
Contributor Author

yerke commented May 27, 2024

@Kobzol done!

Kobzol
Kobzol approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comments have been resolved, so I think that we can merge this.

@Kobzol Kobzol merged commit 5b5f635 into rust-lang:master May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

@ehuss ehuss Awaiting requested review from ehuss

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@ehuss ehuss

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the standalone installers for earlier releases (FIXME)
7 participants
@yerke @rustbot @ojeda @ehuss @Kobzol @Mark-Simulacrum @shepmaster