Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Semverver seems to falsely report breaking change #325

Open
maschad opened this issue Jun 24, 2022 · 0 comments
Open

Semverver seems to falsely report breaking change #325

maschad opened this issue Jun 24, 2022 · 0 comments

Comments

@maschad
Copy link
Contributor

maschad commented Jun 24, 2022

I am not sure why but we are getting a minor version breaking change being reported here even though we had upgraded our minor version after the change.

version bump: 0.45.0 -> (breaking) -> 0.45.1
error: breaking changes in `development_transport`
   --> /home/runner/work/rust-libp2p/rust-libp2p/src/lib.rs:200:1
    |
200 | / pub async fn development_transport(
201 | |     keypair: identity::Keypair,
202 | | ) -> std::io::Result<core::transport::Boxed<(PeerId, core::muxing::StreamMuxerBox)>> {
    | |____________________________________________________________________________________^
    |
    = warning: type error: expected enum `old::identity::Keypair`, found enum `new::identity::Keypair` (breaking)
  
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants