Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Semver doesn't seem to handle multiple-workspace projects well #67

Open
orium opened this issue Sep 16, 2018 · 2 comments
Open

Semver doesn't seem to handle multiple-workspace projects well #67

orium opened this issue Sep 16, 2018 · 2 comments

Comments

@orium
Copy link
Member

orium commented Sep 16, 2018

For instance if you run cargo semver -S url:1.0.0 -C url:1.7.1 this will happen:

thread 'main' panicked at 'assertion failed: self.in_new_crate(new)', src/semcheck/mapping.rs:122:9

The item that cause this lives in the percent_encoding workspace.

@ibabushkin
Copy link
Contributor

Yes, that is indeed an issue. I should have more time to work on the tool soon though :)

@ibabushkin
Copy link
Contributor

Okay, so funnily enough we handle such cases somewhat gracefully (as in do not crash and do reasonable(?) computations) when both the old and the new crate are on-disk (as in, not specified via -C or -S). Other cases fail, because I presume the other crates in the workspace that are often dependencies get dragged in somehow (and possibly translated and so on).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants