Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test on CI: search-tab-change-title-fn-sig.goml #98163

Closed
JohnTitor opened this issue Jun 16, 2022 · 4 comments · Fixed by #99323
Closed

Flaky test on CI: search-tab-change-title-fn-sig.goml #98163

JohnTitor opened this issue Jun 16, 2022 · 4 comments · Fixed by #99323
Assignees
@GuillaumeGomez
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@JohnTitor
Copy link
Member

JohnTitor commented Jun 16, 2022 •
edited

The failure is:

/checkout/src/test/rustdoc-gui/search-tab-change-title-fn-sig.goml search-tab-change-title-fn-sig... FAILED
[ERROR] (line 6) Error: The following CSS selector "#titles" was not found: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:47

That test has failed several times:
@JohnTitor JohnTitor added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jun 16, 2022
@JohnTitor JohnTitor mentioned this issue Jun 16, 2022
Closed
@JohnTitor JohnTitor changed the title Flaky test: search-tab-change-title-fn-sig.goml Flaky test on CI: search-tab-change-title-fn-sig.goml Jun 16, 2022
@GuillaumeGomez GuillaumeGomez self-assigned this Jun 16, 2022
@JohnTitor JohnTitor added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Jun 19, 2022
@JohnTitor
Copy link
Member Author

Another case: #99305 (comment)

@GuillaumeGomez
Copy link
Member

It's all linked to the search. I wonder if we're entering things too fast...

@JohnTitor
Copy link
Member Author

Maybe we could do some retry such a case?

@GuillaumeGomez
Copy link
Member

I have a better idea. :)

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 16, 2022
Merged
@bors bors closed this as completed in 0c6e01b Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flakyness of GUI tests GuillaumeGomez/rust
2 participants
@GuillaumeGomez @JohnTitor