make soft_unstable show up in future breakage reports #116274

RalfJung · 2023-09-29T19:57:39Z

If we want to break these in the future, let's warn users of affected crates.

rustbot · 2023-09-29T19:57:45Z

(rustbot has picked a reviewer for you, use r? to override)

cjgillot · 2023-09-30T12:30:42Z

compiler/rustc_lint_defs/src/builtin.rs

@@ -2457,7 +2457,7 @@ declare_lint! {
    Deny,
    "a feature gate that doesn't break dependent crates",


Should the docs be updated as well?

Why? This still doesn't break dependent crates.

Though I do admit I find this description a bit confusing. It's not a feature gate, not really? But the text also doesn't seem to show up in the output, so... 🤷

RalfJung · 2023-10-07T06:32:43Z

@rust-lang/compiler I assume this will need T-compiler FCP or something like that?

lcnr · 2023-10-11T07:17:02Z

@rfcbot fcp merge

rfcbot · 2023-10-11T07:17:03Z

nagisa · 2023-10-11T07:24:22Z

This PR/FCP could benefit from more text describing what the problem is and why it is being fixed. From what I gather from the diff, this is changing the compiler to start reporting future compatibility lints that are introduced by external crates. Previously we didn’t do that, because users don’t really have especially much agency over those changes IIRC. What changed that this is now no longer a concern?

As a side note, I remember seeing cargo builds saying that dependency builds have this or that many compatibility warnings. Is that no longer sufficient?

RalfJung · 2023-10-11T11:55:31Z

If we want to eventually make these features actually unstable (so the build on stable fails), we should tell users when their dependencies are affected so they can upgrade or try to get in touch with upstream about this. That's the usual lifecycle of a future-compat lint:

start as a regular warning
at some point also show up in dependencies, and become a hard error (those steps can happen in either order)
and then become a hard error

soft_unstable is weird since it's not one particular feature, so we're coupling all affected features together and they go through the lifecycle at the same pace. There's not really anything we can do about that with the current lint design. This probably should have been one lint per soft-unstable feature rather than one catch-all lint...

As a side note, I remember seeing cargo builds saying that dependency builds have this or that many compatibility warnings. Is that no longer sufficient?

This PR has exactly the goal of making cargo show that. Cargo only reports this for compatibility issues that explicit ask for FutureReleaseErrorReportInDeps, so soft_unstable is not currently reported there.

RalfJung · 2023-11-04T10:26:44Z

@Aaron1011 @estebank @nagisa @pnkfelix @wesleywiser friendly reminder that there's a checkbox here patiently waiting for you :)

RalfJung · 2023-12-02T18:05:06Z

@Aaron1011 @estebank @pnkfelix @wesleywiser this FCP is waiting for your comments or approval. :)

rfcbot · 2023-12-14T15:57:36Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-12-24T16:12:36Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

RalfJung · 2023-12-25T10:35:04Z

@cjgillot this is now waiting for review. :)

cjgillot · 2023-12-25T12:35:55Z

@bors r+

bors · 2023-12-25T12:35:57Z

📌 Commit b9acee2 has been approved by cjgillot

It is now in the queue for this repository.

bors · 2023-12-25T16:26:18Z

⌛ Testing commit b9acee2 with merge f8fe517...

bors · 2023-12-25T18:23:47Z

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing f8fe517 to master...

rust-timer · 2023-12-25T19:45:58Z

Finished benchmarking commit (f8fe517): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.7%, -2.4%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.2%, 2.8%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 670.163s -> 668.324s (-0.27%)
Artifact size: 312.56 MiB -> 312.49 MiB (-0.02%)

Pkgsrc changes: * Adapt checksums and patches. Upstream chnages: Version 1.77.0 (2024-03-21) ========================== - [Reveal opaque types within the defining body for exhaustiveness checking.] (rust-lang/rust#116821) - [Stabilize C-string literals.] (rust-lang/rust#117472) - [Stabilize THIR unsafeck.] (rust-lang/rust#117673) - [Add lint `static_mut_refs` to warn on references to mutable statics.] (rust-lang/rust#117556) - [Support async recursive calls (as long as they have indirection).] (rust-lang/rust#117703) - [Undeprecate lint `unstable_features` and make use of it in the compiler.] (rust-lang/rust#118639) - [Make inductive cycles in coherence ambiguous always.] (rust-lang/rust#118649) - [Get rid of type-driven traversal in const-eval interning] (rust-lang/rust#119044), only as a [future compatiblity lint] (rust-lang/rust#122204) for now. - [Deny braced macro invocations in let-else.] (rust-lang/rust#119062) Compiler -------- - [Include lint `soft_unstable` in future breakage reports.] (rust-lang/rust#116274) - [Make `i128` and `u128` 16-byte aligned on x86-based targets.] (rust-lang/rust#116672) - [Use `--verbose` in diagnostic output.] (rust-lang/rust#119129) - [Improve spacing between printed tokens.] (rust-lang/rust#120227) - [Merge the `unused_tuple_struct_fields` lint into `dead_code`.] (rust-lang/rust#118297) - [Error on incorrect implied bounds in well-formedness check] (rust-lang/rust#118553), with a temporary exception for Bevy. - [Fix coverage instrumentation/reports for non-ASCII source code.] (rust-lang/rust#119033) - [Fix `fn`/`const` items implied bounds and well-formedness check.] (rust-lang/rust#120019) - [Promote `riscv32{im|imafc}-unknown-none-elf` targets to tier 2.] (rust-lang/rust#118704) - Add several new tier 3 targets: - [`aarch64-unknown-illumos`] (rust-lang/rust#112936) - [`hexagon-unknown-none-elf`] (rust-lang/rust#117601) - [`riscv32imafc-esp-espidf`] (rust-lang/rust#119738) - [`riscv32im-risc0-zkvm-elf`] (rust-lang/rust#117958) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Implement `From<&[T; N]>` for `Cow<[T]>`.] (rust-lang/rust#113489) - [Remove special-case handling of `vec.split_off (0)`.](rust-lang/rust#119917) Stabilized APIs --------------- - [`array::each_ref`] (https://doc.rust-lang.org/stable/std/primitive.array.html#method.each_ref) - [`array::each_mut`] (https://doc.rust-lang.org/stable/std/primitive.array.html#method.each_mut) - [`core::net`] (https://doc.rust-lang.org/stable/core/net/index.html) - [`f32::round_ties_even`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.round_ties_even) - [`f64::round_ties_even`] (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.round_ties_even) - [`mem::offset_of!`] (https://doc.rust-lang.org/stable/std/mem/macro.offset_of.html) - [`slice::first_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.first_chunk) - [`slice::first_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.first_chunk_mut) - [`slice::split_first_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_first_chunk) - [`slice::split_first_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_first_chunk_mut) - [`slice::last_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.last_chunk) - [`slice::last_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.last_chunk_mut) - [`slice::split_last_chunk`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_last_chunk) - [`slice::split_last_chunk_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.split_last_chunk_mut) - [`slice::chunk_by`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.chunk_by) - [`slice::chunk_by_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.chunk_by_mut) - [`Bound::map`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.map) - [`File::create_new`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.create_new) - [`Mutex::clear_poison`] (https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.clear_poison) - [`RwLock::clear_poison`] (https://doc.rust-lang.org/stable/std/sync/struct.RwLock.html#method.clear_poison) Cargo ----- - [Extend the build directive syntax with `cargo::`.] (rust-lang/cargo#12201) - [Stabilize metadata `id` format as `PackageIDSpec`.] (rust-lang/cargo#12914) - [Pull out as `cargo-util-schemas` as a crate.] (rust-lang/cargo#13178) - [Strip all debuginfo when debuginfo is not requested.] (rust-lang/cargo#13257) - [Inherit jobserver from env for all kinds of runners.] (rust-lang/cargo#12776) - [Deprecate rustc plugin support in cargo.] (rust-lang/cargo#13248) Rustdoc ----- - [Allows links in markdown headings.] (rust-lang/rust#117662) - [Search for tuples and unit by type with `()`.] (rust-lang/rust#118194) - [Clean up the source sidebar's hide button.] (rust-lang/rust#119066) - [Prevent JS injection from `localStorage`.] (rust-lang/rust#120250) Misc ---- - [Recommend version-sorting for all sorting in style guide.] (rust-lang/rust#115046) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add more weirdness to `weird-exprs.rs`.] (rust-lang/rust#119028)

make soft_unstable show up in future breakage reports

b9acee2

rustbot assigned cjgillot Sep 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2023

cjgillot reviewed Sep 30, 2023

View reviewed changes

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 11, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 14, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2023

bors merged commit f8fe517 into rust-lang:master Dec 25, 2023
12 checks passed

rustbot added this to the 1.77.0 milestone Dec 25, 2023

RalfJung deleted the soft_unstable branch December 26, 2023 17:55

apiraino removed the to-announce Announce this issue on triage meeting label Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make soft_unstable show up in future breakage reports #116274

make soft_unstable show up in future breakage reports #116274

RalfJung commented Sep 29, 2023

rustbot commented Sep 29, 2023

cjgillot Sep 30, 2023

RalfJung Sep 30, 2023 •

edited

RalfJung commented Oct 7, 2023

lcnr commented Oct 11, 2023

rfcbot commented Oct 11, 2023 •

edited by estebank

nagisa commented Oct 11, 2023 •

edited

RalfJung commented Oct 11, 2023 •

edited

RalfJung commented Nov 4, 2023

RalfJung commented Dec 2, 2023

rfcbot commented Dec 14, 2023

rfcbot commented Dec 24, 2023

RalfJung commented Dec 25, 2023

cjgillot commented Dec 25, 2023

bors commented Dec 25, 2023

bors commented Dec 25, 2023

bors commented Dec 25, 2023

rust-timer commented Dec 25, 2023

		@@ -2457,7 +2457,7 @@ declare_lint! {
		Deny,
		"a feature gate that doesn't break dependent crates",

make soft_unstable show up in future breakage reports #116274

make soft_unstable show up in future breakage reports #116274

Conversation

RalfJung commented Sep 29, 2023

rustbot commented Sep 29, 2023

cjgillot Sep 30, 2023

Choose a reason for hiding this comment

RalfJung Sep 30, 2023 • edited

Choose a reason for hiding this comment

RalfJung commented Oct 7, 2023

lcnr commented Oct 11, 2023

rfcbot commented Oct 11, 2023 • edited by estebank

nagisa commented Oct 11, 2023 • edited

RalfJung commented Oct 11, 2023 • edited

RalfJung commented Nov 4, 2023

RalfJung commented Dec 2, 2023

rfcbot commented Dec 14, 2023

rfcbot commented Dec 24, 2023

RalfJung commented Dec 25, 2023

cjgillot commented Dec 25, 2023

bors commented Dec 25, 2023

bors commented Dec 25, 2023

bors commented Dec 25, 2023

rust-timer commented Dec 25, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

RalfJung Sep 30, 2023 •

edited

rfcbot commented Oct 11, 2023 •

edited by estebank

nagisa commented Oct 11, 2023 •

edited

RalfJung commented Oct 11, 2023 •

edited