Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview Chapter Followup #674

Open
1 of 16 tasks
mark-i-m opened this issue Apr 14, 2020 · 9 comments
Open
1 of 16 tasks

Overview Chapter Followup #674

mark-i-m opened this issue Apr 14, 2020 · 9 comments
Labels
Easy Might be a good place for a beginner Hard Might require advanced knowledge help wanted Extra attention is needed Medium Might require some prior knowledge or code reading

Comments

@mark-i-m
Copy link
Member

mark-i-m commented Apr 14, 2020

This issue exists to track things we want to improve on. Please add things here:

  • Replace bullets with prose.
  • Perhaps move some of the content about command line parsing, lexing, and parsing to the appropriate chapters.
  • More info on type checking and type inference.
  • Fix some of the TODOs
  • add more links to other parts of the guide
  • add diagrams
  • answer unresolved questions at the bottom
  • figure out where the following happen and add them back to the list of steps
    • type checking
    • trait solving
    • const eval
    • size optimizations
  • Perhaps use more content from https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/history.20of.20typeck.20and.20borrowck about HAIR
  • find out if there are other reasons to use query system beyond incremental
  • improve descriptions of bootstrapping.
  • verify info about parallel rustc effort
@mark-i-m
Copy link
Member Author

cc @rust-lang/wg-rustc-dev-guide

@mark-i-m mark-i-m mentioned this issue Apr 14, 2020
mark-i-m added a commit to mark-i-m/rustc-guide that referenced this issue Apr 18, 2020
With some items added to rust-lang#674

Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>
mark-i-m added a commit that referenced this issue Apr 18, 2020
With some items added to #674

Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>
@mark-i-m mark-i-m added Easy Might be a good place for a beginner Hard Might require advanced knowledge help wanted Extra attention is needed Medium Might require some prior knowledge or code reading labels May 6, 2020
@mark-i-m mark-i-m pinned this issue May 19, 2020
@jyn514
Copy link
Member

jyn514 commented Jun 23, 2020

Replace bullets with prose

This goal is surprising to me, why prose? I find bullets easier to read.

find out if there are other reasons to use query system beyond incremental

You don't need to catalogue all the necessary information ahead of time (you can have unknown knowns). For example lints wouldn't need to state ahead of time whether they needed typeck to run or not: https://discord.com/channels/442252698964721669/443151243398086667/724028959209291817

improve descriptions of bootstrapping

I'm interested in helping with this.

@tshepang
Copy link
Member

I also find bullets more easy... prose can be intimidating.

@mark-i-m
Copy link
Member Author

This goal is surprising to me, why prose? I find bullets easier to read.

That's helpful feedback. I think the original motivation was that the bullet points in this chapter already contain paragraphs, so prose may be a bit more natural...

I'm interested in helping with this.

Awesome! Thanks :)

So IIRC, that was referring to this para: https://rustc-dev-guide.rust-lang.org/overview.html#bootstrapping

Basically, there was a feeling that it moves too fast and wouldn't make sense to new comers. Any thoughts?

@jyn514
Copy link
Member

jyn514 commented Jun 23, 2020

This is really confusing. It would be better phrased as

one of the major users of Rust is the rust compiler

  • There's no mention of src/bootstrap here.
  • There's no overview of different stages. This is especially bad because rustc numbers them differently than most compilers.

In general I think it would be better to have a separate page for bootstrap and replace this section with a link to that page. Otherwise there's too much in too little time.

I have more thoughts but I think they would be better placed in a PR making these changes directly :P

@jyn514
Copy link
Member

jyn514 commented Jun 23, 2020

Oh hmm I see there's a separate building/bootstrap.md page. Maybe most of this section could be moved there?

@jyn514
Copy link
Member

jyn514 commented Jul 14, 2020

find out if there are other reasons to use query system beyond incremental

I'm interested in helping with this, I had to mess with queries a lot for rust-lang/rust#73566.

@mark-i-m
Copy link
Member Author

@jyn514 That would be great!

@tshepang
Copy link
Member

this is pinned... is it current, should it remain open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Might be a good place for a beginner Hard Might require advanced knowledge help wanted Extra attention is needed Medium Might require some prior knowledge or code reading
Projects
None yet
Development

No branches or pull requests

3 participants