Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourse Integration #363

Open
XAMPPRocky opened this issue Jun 16, 2020 · 5 comments
Open

Discourse Integration #363

XAMPPRocky opened this issue Jun 16, 2020 · 5 comments

Comments

@XAMPPRocky
Copy link
Member

Discourse has the notion of groups which can be given different privacy and permissions to different forums, it would be nice if we could sync our discourse forums to have groups that match the teams in the team repository. The implementation should be a straightforward addition as discourse's API is relatively simple. The most amount of work would probably be getting everyone to add their discourse usernames to the team repo.

@pietroalbini
Copy link
Member

I don't think adding users IDs of everyone in the team repo is the right approach: while that's needed occasionally (like Discord and maybe Zulip -- even though I have an idea on how to remove the need for setting a Zulip ID) is a huge churn, and we should avoid that at all costs.

While it's more expensive regarding API calls, we can get each user's ID from their email address by calling /admin/users/list/all.json?email=foo@example.com, using the email address they have in the team repository.

@XAMPPRocky
Copy link
Member Author

While it's more expensive regarding API calls, we can get each user's ID from their email address by calling /admin/users/list/all.json?email=foo@example.com, using the email address they have in the team repository.

Well what's expensive in this context? Like I don't know how what limits we have on the discourse API. If it's just sub-optimal then I think that approach is fine.

@pietroalbini
Copy link
Member

I'm not aware of any rate limits, and we can tweak them since we're the owners of the instance.

@Manishearth
Copy link
Member

Neat idea.

Teams don't use discourse that much (and when they do their team status isn't as important) so this hasn't been needed as much. But it doesn't hurt!

@joshtriplett
Copy link
Member

I'd like to see this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants