Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i128 no_std #83

Closed
zendurix opened this issue Aug 27, 2020 · 2 comments
Closed

i128 no_std #83

zendurix opened this issue Aug 27, 2020 · 2 comments

Comments

@zendurix
Copy link

zendurix commented Aug 27, 2020

README says that this crate supports no_std, however it depends on num-traits with i128 feature (even when run with no default features).
When I test some program that is dependand on num complex, with no-std-check (https://github.com/mystor/cargo-no-std-check)
I get this error: thread 'main' panicked at 'i128 support was not detected!

@cuviper
Copy link
Member

cuviper commented Aug 27, 2020

I haven't seen cargo-no-std-check before, but it looks like it's using RUSTC_WRAPPER to intercept and rewrite target arguments. The autocfg crate will need to support this as well, otherwise feature detection is going to be broken in this use case. But in normal use, I expect it's still be fine.

There shouldn't be any real problem with i128 on no_std targets though. I have thought about relaxing those checks such that if the feature is requested, it will go ahead and be used without bothering to probe with autocfg.

@cuviper
Copy link
Member

cuviper commented Oct 29, 2020

This should be fixed by num-traits 0.2.13 via rust-num/num-traits#185.
For the broader problem of RUSTC_WRAPPER, I'll leave that to cuviper/autocfg#26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants