Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML: Handle DefIndexField (real hardware) #184

Open
alnyan opened this issue Aug 23, 2023 · 0 comments
Open

AML: Handle DefIndexField (real hardware) #184

alnyan opened this issue Aug 23, 2023 · 0 comments

Comments

@alnyan
Copy link
Contributor

alnyan commented Aug 23, 2023

Hi,
I was trying to integrate the aml/acpi crates into my kernel and found out that some of the real-hardware opcodes are NYI.

I'm currently working on implementing DefIndexField myself, but there's problem that might require significant changes to the aml crate: as IndexFields require writes to their index fields even when reading, this means functions like as_integer/as_string/as_buffer/etc as well as the read_field also perform writes and thus require mutable ref to AmlContext, which breaks lots of other code. A simple workaround would be to add a separate AmlType for IndexFields, but I don't think this is correct as per specification.

So, if you can suggest which way is better, I can finish this feature and make a PR.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant