-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Re-design SystemTable/BootServices/RuntimeServices #893
Comments
This would also make the uefi-services crate (in its current form) deprecated as we'd already have a static global of boot services in the uefi crate. I'd be in favor of deprecating uefi-services as well (#563 (comment)) eventually. |
I'm cautiously in favor of this proposal. We did something along these lines in #478, where we added a global image handle that gets set automatically by the The only downsides I can think of so far are:
|
Expanding on downside 1 from my list above with a related problem: Structs that currently have a lifetime tied to BootServices (like |
I've been playing around with this a bit, to get an idea of what it would look like in practice. I put up what I have for discussion: #905 A few notes:
|
A few more thoughts in favor of adding global pointers:
|
Let's discuss #841 again which was unfortunately closed without further discussions.
Personally, I am in strong favor of the proposed API design. I copy the key points here again:
I'm especially in strong favor of renaming
#[entry]
to#[efi_main]
, simplify the function signature and not having to manually passbs
to so many functions. Instead, it should be provided by a global static.The text was updated successfully, but these errors were encountered: