code review

rust-phf · Nov 19, 2014 · 88d54c2 · 88d54c2
1 parent 7ced000
commit 88d54c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/phf/src/map.rs b/phf/src/map.rs
@@ -103,8 +103,8 @@ impl<K, V> Map<K, V> {
     }
 
     /// Like `get`, but returns both the key and the value.
-    pub fn get_kv<Sized? T>(&self, key: &T) -> Option<&(K, V)> where T: PhfHash+Equiv<K> {
-        self.get_entry(key, |k| key.equiv(k))
+    pub fn get_kv<Sized? T>(&self, key: &T) -> Option<(&K, &V)> where T: PhfHash+Equiv<K> {
+        self.get_entry(key, |k| key.equiv(k)).map(|e| (&e.0, &e.1))
     }
 
     /// Like `get`, but can operate on any type that is equivalent to a key.
@@ -120,8 +120,8 @@ impl<K, V> Map<K, V> {
 
     /// Like `get_kv`, but can operate on any type that is equivalent to a
     /// key.
-    pub fn get_kv_equiv<Sized? T>(&self, key: &T) -> Option<&(K, V)> where T: PhfHash+Equiv<K> {
-        self.get_entry(key, |k| key.equiv(k))
+    pub fn get_kv_equiv<Sized? T>(&self, key: &T) -> Option<(&K, &V)> where T: PhfHash+Equiv<K> {
+        self.get_entry(key, |k| key.equiv(k)).map(|e| (&e.0, &e.1))
     }
 
     /// Returns an iterator over the key/value pairs in the map.

diff --git a/phf/src/ordered_map.rs b/phf/src/ordered_map.rs
@@ -116,8 +116,8 @@ impl<K, V> OrderedMap<K, V> {
     }
 
     /// Like `get`, but returns both the key and the value.
-    pub fn get_kv<Sized? T>(&self, key: &T) -> Option<&(K, V)> where T: PhfHash+Equiv<K> {
-        self.get_entry(key, |k| key.equiv(k)).map(|(_, r)| r)
+    pub fn get_kv<Sized? T>(&self, key: &T) -> Option<(&K, &V)> where T: PhfHash+Equiv<K> {
+        self.get_entry(key, |k| key.equiv(k)).map(|(_, e)| (&e.0, &e.1))
     }
 
     /// Like `get`, but can operate on any type that is equivalent to a key.
@@ -139,8 +139,8 @@ impl<K, V> OrderedMap<K, V> {
 
     /// Like `get_kv`, but can operate on any type that is equivalent to a
     /// key.
-    pub fn get_kv_equiv<Sized? T>(&self, key: &T) -> Option<&(K, V)> where T: PhfHash+Equiv<K> {
-        self.get_entry(key, |k| key.equiv(k)).map(|(_, r)| r)
+    pub fn get_kv_equiv<Sized? T>(&self, key: &T) -> Option<(&K, &V)> where T: PhfHash+Equiv<K> {
+        self.get_entry(key, |k| key.equiv(k)).map(|(_, e)| (&e.0, &e.1))
     }
 
     /// Returns an iterator over the key/value pairs in the map.