Skip to content

Commit

Permalink
Rename Set and OrderedSet iterators
Browse files Browse the repository at this point in the history
They're now in line with RFC 344
  • Loading branch information
sfackler committed Dec 15, 2014
1 parent fc4829a commit 9103fc5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 15 deletions.
14 changes: 7 additions & 7 deletions phf/src/ordered_set.rs
Expand Up @@ -85,8 +85,8 @@ impl<T> OrderedSet<T> {
/// Returns an iterator over the values in the set.
///
/// Values are returned in the same order in which they were defined.
pub fn iter<'a>(&'a self) -> Entries<'a, T> {
Entries { iter: self.map.keys() }
pub fn iter<'a>(&'a self) -> Iter<'a, T> {
Iter { iter: self.map.keys() }
}
}

Expand All @@ -111,11 +111,11 @@ impl<T> OrderedSet<T> where T: Eq + PhfHash {
}

/// An iterator over the values in a `OrderedSet`.
pub struct Entries<'a, T:'a> {
pub struct Iter<'a, T:'a> {
iter: ordered_map::Keys<'a, T, ()>,
}

impl<'a, T> Iterator<&'a T> for Entries<'a, T> {
impl<'a, T> Iterator<&'a T> for Iter<'a, T> {
#[inline]
fn next(&mut self) -> Option<&'a T> {
self.iter.next()
Expand All @@ -127,14 +127,14 @@ impl<'a, T> Iterator<&'a T> for Entries<'a, T> {
}
}

impl<'a, T> DoubleEndedIterator<&'a T> for Entries<'a, T> {
impl<'a, T> DoubleEndedIterator<&'a T> for Iter<'a, T> {
#[inline]
fn next_back(&mut self) -> Option<&'a T> {
self.iter.next_back()
}
}

impl<'a, T> RandomAccessIterator<&'a T> for Entries<'a, T> {
impl<'a, T> RandomAccessIterator<&'a T> for Iter<'a, T> {
#[inline]
fn indexable(&self) -> uint {
self.iter.indexable()
Expand All @@ -146,5 +146,5 @@ impl<'a, T> RandomAccessIterator<&'a T> for Entries<'a, T> {
}
}

impl<'a, T> ExactSizeIterator<&'a T> for Entries<'a, T> {}
impl<'a, T> ExactSizeIterator<&'a T> for Iter<'a, T> {}

14 changes: 6 additions & 8 deletions phf/src/set.rs
Expand Up @@ -77,8 +77,8 @@ impl<T> Set<T> {
/// Returns an iterator over the values in the set.
///
/// Values are returned in an arbitrary but fixed order.
pub fn iter<'a>(&'a self) -> Items<'a, T> {
Items { iter: self.map.keys() }
pub fn iter<'a>(&'a self) -> Iter<'a, T> {
Iter { iter: self.map.keys() }
}
}

Expand All @@ -100,11 +100,11 @@ impl<T> Set<T> where T: Eq + PhfHash {
}

/// An iterator over the values in a `Set`.
pub struct Items<'a, T:'static> {
pub struct Iter<'a, T:'static> {
iter: map::Keys<'a, T, ()>,
}

impl<'a, T> Iterator<&'a T> for Items<'a, T> {
impl<'a, T> Iterator<&'a T> for Iter<'a, T> {
fn next(&mut self) -> Option<&'a T> {
self.iter.next()
}
Expand All @@ -114,12 +114,10 @@ impl<'a, T> Iterator<&'a T> for Items<'a, T> {
}
}

impl<'a, T> DoubleEndedIterator<&'a T> for Items<'a, T> {
impl<'a, T> DoubleEndedIterator<&'a T> for Iter<'a, T> {
fn next_back(&mut self) -> Option<&'a T> {
self.iter.next_back()
}
}

impl<'a, T> ExactSizeIterator<&'a T> for Items<'a, T> {}


impl<'a, T> ExactSizeIterator<&'a T> for Iter<'a, T> {}

0 comments on commit 9103fc5

Please sign in to comment.