fix: remove now-unnecessary proc-macro-hack crate usage
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as a draft PR, since apparently I haven't gotten things to recompile successfully yet with a sample upstream crate like |
|
Aha, figured it out. I forgot that |
|
Looks like I have some tests to fix -- will take a look next week. :) EDIT: NVM, it was easier than I thought, hehe! |
Resolves <#255>. This resolves an issue with Windows Defender identifying `proc-macro-hack` as threats. It also sheds a depedency that is no longer necessary, now that the MSRV of this crate is 1.46 and `proc-macro-hack` is only useful for providing support for Rust versions 1.31 through 1.45. Per [upstream](https://github.com/dtolnay/proc-macro-hack): > **Note:** _As of Rust 1.45 this crate is superseded by native support for #\[proc\_macro\] in > expression position. Only consider using this crate if you care about supporting compilers between > 1.31 and 1.45._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #255.
This resolves an issue with Windows Defender identifying
proc-macro-hackas threats. It also sheds a depedency that is no longer necessary, now that the MSRV of this crate is 1.46 andproc-macro-hackis only useful for providing support for Rust versions 1.31 through 1.45. Per upstream: