serde for BlockRng, ReseedingRng and ReadRng #1130
Merged
+13
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1101, which also discussed serde for other RNGs.
ReadRng
: probably useless?ReseedingRng
: probably useless since the reseeder will normally be a non-deterministic RNGBlockRng
: required forReseedingRng
and I guess was never picked up in previous tests?rand/serde1
now requiresrand_core/serde1
, required forReseedingRng
and probably sensibleOsRng
: useless, and easy to skip as a field in structsStdRng
orSmallRng
: as @kazcw points out, non-stable serialisation would be a pit-fallHc128Rng
: would require https://crates.io/crates/serde-big-array or some workaround until some future MSRV bump but I doubt anyone cares anywayI'm tempted to remove the
ReadRng
and possiblyReseedingRng
support but there doesn't seem a good reason either way. Thoughts?