Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double panic mentioning for RAII guards #327

Open
nandesu-utils opened this issue Nov 27, 2022 · 1 comment
Open

Add double panic mentioning for RAII guards #327

nandesu-utils opened this issue Nov 27, 2022 · 1 comment
Labels
A-pattern Area: Content about Patterns C-amendment Category: Amendments to existing content good first issue Good for newcomers

Comments

@nandesu-utils
Copy link

I think it would be nice to mention that one should be careful when writing drop implementations on guards relatively to the double panic possibility when they find out about this pattern for the first time or are unaware of double panicking generally.

It might help someone inexperienced I suppose.
@simonsan
Copy link
Collaborator

simonsan commented Nov 28, 2022 •
edited

Maybe makes sense to add that directly to #323

@simonsan simonsan added good first issue Good for newcomers A-pattern Area: Content about Patterns C-amendment Category: Amendments to existing content labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pattern Area: Content about Patterns C-amendment Category: Amendments to existing content good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonsan @nandesu-utils