Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should X display/connection handles be nullable? #141

Open
madsmtm opened this issue Aug 24, 2023 · 3 comments
Open

Should X display/connection handles be nullable? #141

madsmtm opened this issue Aug 24, 2023 · 3 comments

Comments

@madsmtm
Copy link
Member

madsmtm commented Aug 24, 2023

XlibDisplayHandle.display and XcbDisplayHandle.connection are nullable; should they be?

Previously discussed in #136.

@notgull
Copy link
Member

notgull commented Aug 24, 2023

If I remember correctly, display handles can be null for EGL. I've changed my mind since my posts in #136, I think allowing this use case is worth it.

@kchibisov
Copy link
Member

Yes, there's a thing called EGL_DEFAULT_DISPLAY, so it'll use the display somehow automatically. Also it does open connection under the hood with xcb iirc the mesa code.

@i509VCB
Copy link

i509VCB commented Nov 11, 2023

Whether null is correct depends on the context. Like kchibisov, for EGL it is valid. Meanwhile in Vulkan, you must provide a valid pointer to a display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants