Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WebWindowHandle? #157

Open
madsmtm opened this issue Dec 22, 2023 · 2 comments
Open

Remove WebWindowHandle? #157

madsmtm opened this issue Dec 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@madsmtm
Copy link
Member

madsmtm commented Dec 22, 2023

We now have WebCanvasWindowHandle and WebOffscreenCanvasWindowHandle, which are much safer, so we should probably work on removing WebWindowHandle.

Probably with a deprecation period first.
@madsmtm madsmtm added the enhancement New feature or request label Dec 22, 2023
@madsmtm madsmtm mentioned this issue Dec 22, 2023
Open
@daxpedda
Copy link
Member

I'm in favor of this as well.

I've implemented support for the other handles in some known crates with success so far:

@daxpedda daxpedda mentioned this issue Jan 2, 2024
Draft
@notgull
Copy link
Member

notgull commented Feb 4, 2024

I think we should wait to remove these handles until we have a stable (post-1.0) way to refer to web handles, whether it's wasm-bindgen or the new wit-bindgen thing that's coming out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daxpedda @madsmtm @notgull