Bad network condition on client side cause multi-typing

[ddddavid-he]

Bug Description

When connecting to remote computer in unstable network connections, rustdesk will perform multiple strikes on a single keystroke during typing. (as shown in the screenshot below)

How to Reproduce

type some word in unstable network connections

Expected Behavior

Type in client, do the same in remote.

Operating system(s) on local side and remote side

Windows 11 -> Debian 12 (KDE Plasma 5)

RustDesk Version(s) on local side and remote side

1.2.3 -> 1.2.4

Screenshots

Additional Context

No response

[rustdesk]

@fufesou to solve this (local press down, but immediate up event is sent to remote late because of network delay, remote linux will think it is a long press), we need send press event (up+down) for every non-modifier down event. To handle long-press, you need to have a timer to send multiple press until up event. But Windows / Osx / Linux have different long press behavior, I remember Windows generates multiple down events for long press, please confirm.

But this also has bad effect.

[fufesou]

Windows generates multiple down events for long press

Yes, it generates multiple down events.

[PiratesIRC]

I have the same issue, but it only happens when I am typing into VMs on the computer that I am remoted into. The computer I am logging in with and logging in to are connected via ethernet and the rust server is self-hosted on the same computer that is hosting the VMs. This started when I upgraded to the latest version of the rust client.

[harshRn]

Hi @rustdesk
Seeing that this is not taken up by anyone, could I take a crack at it ? not sure, how involved the changes would be, but I would be glad to be of some help.
Thanks!

[rustdesk]

@harshRn of course.