Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --locked to installation instructions of our tooling #1152

Closed
amousset opened this issue Mar 23, 2024 · 3 comments
Closed

Add --locked to installation instructions of our tooling #1152

amousset opened this issue Mar 23, 2024 · 3 comments

Comments

@amousset
Copy link
Member

The installation instructions (especially for cargo-audit) do not use the lockfile of the repository, but use the latest compatible versions of the dependencies. This has lead to breaking new installations of cargo-audit for one day due to incompatible gix dependencies (Byron/gitoxide#1328).
The main drawback if this switch is that it would make us responsible for releasing security upgrades when one of our dependencies is affected by a vulnerability, but we already have to tooling in place to detect and fix vulnerabilities.

The practices regarding cargo install are not well established in the ecosystem yet (recent RFC opened to change cargo's default behavior), but I think --locked is what makes more sense now in our context.

@tarcieri
Copy link
Member

Seems ok as a stopgap given recent breakages

@tarcieri
Copy link
Member

Separately it'd probably be good for gix/tame-index to adopt a tool like cargo-semver-checks to detect these sorts of breakages automatically?

@Shnatsel
Copy link
Member

gix has already adopted it, but the tool is far from complete. It did not catch the recent reqwest issue that only surfaced at runtime. I believe it also doesn't catch version changes in re-exports, which is what broke semver for tame-index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants