Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webworkers panic if serialisation fails #271

Open
gilescope opened this issue Nov 8, 2022 · 0 comments
Open

Webworkers panic if serialisation fails #271

gilescope opened this issue Nov 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@gilescope
Copy link

One bad reply kills webapp

bincode::deserialize(&data).expect("can't deserialize an worker message")
will panic if a message is sent across with contents that are not deserialisable. There's some requests that bincode can't handle ( DeserializeAnyNotSupported ) - Ideally this should be a regular error rather than a panic as it should be up to the library user to decide if this situation is terminal or not (one bad message may not be the end of the world).

@gilescope gilescope added the bug Something isn't working label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant