Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the wasm relocations custom section if available #73

Open
fitzgen opened this issue Jun 25, 2018 · 1 comment
Open

Use the wasm relocations custom section if available #73

fitzgen opened this issue Jun 25, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 25, 2018

It will actually tell us which functions are using which data. The parity_wasm crate also parses the relocations section, so it shouldn't be too hard to add support for.

If we did this, and our results are noticably better when we have relocations, then we should also document how to build rust to wasm and preserve relocations.

@fitzgen fitzgen added the help wanted Extra attention is needed label Jun 25, 2018
@kjvalencik
Copy link

👋 This is a problem I frequently have. Relocations can cause nonsensical results in twiggy paths for data ownership. My workaround has been to decompile to wat and inspect the data section manually, but this is time consuming.

I'm interested in working on this feature. Can you point me in the right direction for building Rust to WASM with a relocations section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants