Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to release a new version of web-sys #3530

Closed
stephanemagnenat opened this issue Jul 20, 2023 · 13 comments · Fixed by #3676
Closed

Request to release a new version of web-sys #3530

stephanemagnenat opened this issue Jul 20, 2023 · 13 comments · Fixed by #3676

Comments

@stephanemagnenat
Copy link

Motivation

I need WorkerGlobalScope.performance for adding timing support in web workers in Rust CV.

Proposed Solution

A new minor release.

@daxpedda
Copy link
Collaborator

I would have liked to fix #3483 first, but unfortunately we don't seem to have the time.

@stephanemagnenat if you replicate #3475 it would help to get a release now instead of later.

@stephanemagnenat
Copy link
Author

@daxpedda thanks for the fast answer. Is there a script to bump minor versions, or is it a manual process so far?

@daxpedda
Copy link
Collaborator

AFAIK a manual process. It should be straightforward with a couple of search-and-replace.

@gabrielDevlog
Copy link

Hi,

A release would be great. Is there any ETA for this ?

Thanks

@daxpedda
Copy link
Collaborator

daxpedda commented Oct 7, 2023

There is none AFAIK.

You can get the process started by replicating #3475.

@gabrielDevlog
Copy link

gabrielDevlog commented Oct 7, 2023

Ok i'll try. Should i follow this process ? https://rustwasm.github.io/docs/wasm-bindgen/contributing/publishing.html

@daxpedda
Copy link
Collaborator

daxpedda commented Oct 7, 2023

If you just scroll up and look at the earlier discussion you will find all your answers.

Ok i'll try. Should i follow this process ? https://rustwasm.github.io/docs/wasm-bindgen/contributing/publishing.html

I've done it manually so far because I didn't know about this tool, feel free to try it though.

@ranile
Copy link
Collaborator

ranile commented Oct 9, 2023

@daxpedda do you have permissions to make a release? I was thinking of setting up a GitHub actions workflow for it, but I don't have the permissions on crates.io and a secret needs be added before publishing can be done

@daxpedda
Copy link
Collaborator

daxpedda commented Oct 9, 2023

I do not, but the way it worked until now is to set everything up and ping Alex Crichton.
Making an action for it would be ideal though!

@gabrielDevlog
Copy link

Well I'm trying manually but its not as easy as it seems. How do you get this value "APPROVED_SCHEMA_FILE_HASH" ?

https://github.com/rustwasm/wasm-bindgen/pull/3475/files#diff-515c29e8b5cfb75260c999069bc92df2bf301e4bbeddafd858b269cfac79d9f4R11

@daxpedda
Copy link
Collaborator

You can run this test to see what the value is supposed to be:

#[test]
fn schema_version() {
assert_eq!(env!("SCHEMA_FILE_HASH"), APPROVED_SCHEMA_FILE_HASH)
}

@daxpedda
Copy link
Collaborator

daxpedda commented Oct 13, 2023

In the meantime, the schema was already bumped in #3651.

@gabrielDevlog
Copy link

Just to let you know, I haven't had the time to take care of it yet, and I probably won't next week either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants