Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStreamReadResult methods wrong? #3553

Closed
andrewbaxter opened this issue Aug 10, 2023 · 1 comment
Closed

ReadableStreamReadResult methods wrong? #3553

andrewbaxter opened this issue Aug 10, 2023 · 1 comment
Labels

Comments

@andrewbaxter
Copy link

Describe the Bug

https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.ReadableStreamReadResult.html

I think done and value should return bool/jsvalue rather than take them as parameters.

I'm not 100% sure about conventions, but AFAICT this is a result of a read() call for extracting data so would never be constructed by hand. https://stackoverflow.com/questions/75141183/how-to-select-a-file-as-bytes-or-text-in-rust-wasm cites having an issue with it. https://github.com/MattiasBuelens/wasm-streams/blob/main/src/readable/sys.rs#L176 shows what I expected the interface to be.

I didn't see an existing issue so I'm opening this for clarity.

@daxpedda
Copy link
Collaborator

Duplicate of #1793.
See #2782 as well.

@daxpedda daxpedda closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants